Bug 231014 – Move canCompositeClipPath to RenderLayer

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Rob Buis]

Move canCompositeClipPath to RenderLayer.

[Rob Buis]

Created attachment 439710 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 439710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439710&action=review

> Source/WebCore/rendering/RenderLayer.h:241
> +    bool canCompositeClipPath() const;

Moving it here has added ambiguity. It's not clear if this is "if this layer were composited, can it composite clip-path", or "is this layer composited and has a clip path and can composite it".

[Rob Buis]

Created attachment 439751 [details]
Patch

[Rob Buis]

Comment on attachment 439710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439710&action=review

>> Source/WebCore/rendering/RenderLayer.h:241
>> +    bool canCompositeClipPath() const;
> 
> Moving it here has added ambiguity. It's not clear if this is "if this layer were composited, can it composite clip-path", or "is this layer composited and has a clip path and can composite it".

Fair enough, I did another stab.
To be clear, what I do not like about current code:
- unneeded layer accessing
- unneeded ASSERTs
Of these to me the ASSERTs are more annoying. Note that this is not high priority at all but let me know if you think we can make this code a bit nicer/more efficient this way or some other.

[Rob Buis]

Comment on attachment 439710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439710&action=review

>>> Source/WebCore/rendering/RenderLayer.h:241
>>> +    bool canCompositeClipPath() const;
>> 
>> Moving it here has added ambiguity. It's not clear if this is "if this layer were composited, can it composite clip-path", or "is this layer composited and has a clip path and can composite it".
> 
> Fair enough, I did another stab.
> To be clear, what I do not like about current code:
> - unneeded layer accessing
> - unneeded ASSERTs
> Of these to me the ASSERTs are more annoying. Note that this is not high priority at all but let me know if you think we can make this code a bit nicer/more efficient this way or some other.

Nm, thanks :)

[Rob Buis]

Comment on attachment 439710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439710&action=review

>>> Source/WebCore/rendering/RenderLayer.h:241
>>> +    bool canCompositeClipPath() const;
>> 
>> Moving it here has added ambiguity. It's not clear if this is "if this layer were composited, can it composite clip-path", or "is this layer composited and has a clip path and can composite it".
> 
> Fair enough, I did another stab.
> To be clear, what I do not like about current code:
> - unneeded layer accessing
> - unneeded ASSERTs
> Of these to me the ASSERTs are more annoying. Note that this is not high priority at all but let me know if you think we can make this code a bit nicer/more efficient this way or some other.

Nm, thanks :)

[EWS]

Committed r283340 (242357@main): <https://commits.webkit.org/242357@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439751 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83737585>