| Summary: | Move canCompositeClipPath to RenderLayer | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||
| Component: | Layout and Rendering | Assignee: | Rob Buis <rbuis> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Rob Buis
2021-09-30 02:37:13 PDT
Created attachment 439710 [details]
Patch
Comment on attachment 439710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439710&action=review > Source/WebCore/rendering/RenderLayer.h:241 > + bool canCompositeClipPath() const; Moving it here has added ambiguity. It's not clear if this is "if this layer were composited, can it composite clip-path", or "is this layer composited and has a clip path and can composite it". Created attachment 439751 [details]
Patch
Comment on attachment 439710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439710&action=review >> Source/WebCore/rendering/RenderLayer.h:241 >> + bool canCompositeClipPath() const; > > Moving it here has added ambiguity. It's not clear if this is "if this layer were composited, can it composite clip-path", or "is this layer composited and has a clip path and can composite it". Fair enough, I did another stab. To be clear, what I do not like about current code: - unneeded layer accessing - unneeded ASSERTs Of these to me the ASSERTs are more annoying. Note that this is not high priority at all but let me know if you think we can make this code a bit nicer/more efficient this way or some other. Comment on attachment 439710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439710&action=review >>> Source/WebCore/rendering/RenderLayer.h:241 >>> + bool canCompositeClipPath() const; >> >> Moving it here has added ambiguity. It's not clear if this is "if this layer were composited, can it composite clip-path", or "is this layer composited and has a clip path and can composite it". > > Fair enough, I did another stab. > To be clear, what I do not like about current code: > - unneeded layer accessing > - unneeded ASSERTs > Of these to me the ASSERTs are more annoying. Note that this is not high priority at all but let me know if you think we can make this code a bit nicer/more efficient this way or some other. Nm, thanks :) Comment on attachment 439710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439710&action=review >>> Source/WebCore/rendering/RenderLayer.h:241 >>> + bool canCompositeClipPath() const; >> >> Moving it here has added ambiguity. It's not clear if this is "if this layer were composited, can it composite clip-path", or "is this layer composited and has a clip path and can composite it". > > Fair enough, I did another stab. > To be clear, what I do not like about current code: > - unneeded layer accessing > - unneeded ASSERTs > Of these to me the ASSERTs are more annoying. Note that this is not high priority at all but let me know if you think we can make this code a bit nicer/more efficient this way or some other. Nm, thanks :) Committed r283340 (242357@main): <https://commits.webkit.org/242357@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439751 [details]. |