Cocoa GraphicsContextGLOpenGL should not be used by GraphicsContextGLCVANGLE

• Component: WebGL
• Status: RESOLVED FIXED

[Kimmo Kinnunen]

Cocoa GraphicsContextGLOpenGL should not be used by GraphicsContextGLCVANGLE.
Makes it more complex to develop features related to compositor platform layers, as GraphicsContextGLOpenGL "draws to" a platform layer
but GraphicsContextGLCVANGLE shouldn't have one.

[Kimmo Kinnunen]

Created attachment 439731 [details]
Patch

[Kimmo Kinnunen]

Created attachment 439732 [details]
Patch

[Kimmo Kinnunen]

Created attachment 439747 [details]
Patch

[Kenneth Russell]

Comment on attachment 439747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439747&action=review

Since the underlying ANGLE context relationships haven't changed - still creating a separate shared context for video uploads, with the same parameters - this looks good to me. Agree this is just a refactor. The win failure looks like an unrelated flake. r+

> Source/WebCore/platform/graphics/cocoa/ANGLEUtilitiesCocoa.h:37
> +void* createPbufferAndAttachIOSurface(EGLDisplay, EGLConfig, GLenum target, EGLint usageHint, GLenum internalFormat, GLsizei width, GLsizei height, GLenum type, IOSurfaceRef, GLuint plane);

Would it be helpful to put these two free functions in another namespace or as static methods on a class, just to have a little better scoping?

[EWS]

Committed r283362 (242371@main): <https://commits.webkit.org/242371@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439747 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83762759>