Bug 231004

Summary:

Replace the confusing isPinnedForScrollDelta() logic with code that uses BoxSide

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Scrolling

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+

Description Simon Fraser (smfr) 2021-09-29 21:13:03 PDT

Replace the conusing isPinnedForScrollDelta() logic with code that uses BoxSide

Comment 1 Simon Fraser (smfr) 2021-09-29 21:15:39 PDT

Created attachment 439699 [details]
Patch

Comment 2 Simon Fraser (smfr) 2021-09-30 10:58:51 PDT

Created attachment 439760 [details]
Patch

Comment 3 Tim Horton 2021-09-30 11:01:31 PDT

Comment on attachment 439760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439760&action=review

> Source/WebCore/ChangeLog:3
> +        Replace the conusing isPinnedForScrollDelta() logic with code that uses BoxSide

"conusing"

Comment 4 Simon Fraser (smfr) 2021-09-30 13:59:07 PDT

https://trac.webkit.org/changeset/283335/webkit

Comment 5 Radar WebKit Bug Importer 2021-09-30 14:00:23 PDT

<rdar://problem/83736453>