Bug 230995

Summary: [webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: Tools / TestsAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: Basuke.Suzuki, darin, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230725    
Attachments:
Description Flags
PATCH none

Description Basuke Suzuki 2021-09-29 15:45:38 PDT
This is the error.

> python3 Tools/Scripts/check-webkit-style
>  in dir /Volumes/Data/worker/Style-EWS/build (timeout 1200 secs)
>  watching logfiles {}
>  argv: [b'python3', b'Tools/Scripts/check-webkit-style']
>  using PTY: False
> ERROR: Source/WTF/wtf/Assertions.h:203:  LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> ERROR: Source/WTF/wtf/Assertions.h:609:  More than one command on the same line  [whitespace/newline] [4]
> Total errors found: 2 in 3 files
> program finished with exit code 1
> elapsedTime=6.630763
Comment 1 Basuke Suzuki 2021-09-29 15:51:46 PDT
Created attachment 439673 [details]
PATCH
Comment 2 EWS 2021-09-29 16:53:39 PDT
Committed r283282 (242309@main): <https://commits.webkit.org/242309@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439673 [details].
Comment 3 Radar WebKit Bug Importer 2021-09-29 16:54:23 PDT
<rdar://problem/83695013>