| Summary: |
[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error |
| Product: |
WebKit
|
Reporter: |
Basuke Suzuki <Basuke.Suzuki> |
| Component: |
Tools / Tests | Assignee: |
Basuke Suzuki <Basuke.Suzuki> |
| Status: |
RESOLVED
FIXED
|
|
|
| Severity: |
Normal
|
CC: |
Basuke.Suzuki, darin, ews-watchlist, glenn, jbedard, webkit-bug-importer
|
| Priority: |
P2
|
Keywords: |
InRadar |
| Version: |
WebKit Nightly Build | |
|
| Hardware: |
Unspecified | |
|
| OS: |
Unspecified | |
|
| Bug Depends on: |
|
|
|
| Bug Blocks: |
230725
|
|
|
| Attachments: |
| Description |
Flags |
|
PATCH
|
none
|
|
This is the error. > python3 Tools/Scripts/check-webkit-style > in dir /Volumes/Data/worker/Style-EWS/build (timeout 1200 secs) > watching logfiles {} > argv: [b'python3', b'Tools/Scripts/check-webkit-style'] > using PTY: False > ERROR: Source/WTF/wtf/Assertions.h:203: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] > ERROR: Source/WTF/wtf/Assertions.h:609: More than one command on the same line [whitespace/newline] [4] > Total errors found: 2 in 3 files > program finished with exit code 1 > elapsedTime=6.630763