Bug 230989

Summary: Add a default return value in convertToExceptionCode
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: WebKit Misc.Assignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231706    
Attachments:
Description Flags
Patch
none
Patch none

Sihui Liu
Reported 2021-09-29 15:13:53 PDT
...
Attachments
Patch (1.36 KB, patch)
2021-09-29 15:15 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2021-09-29 15:22 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2021-09-29 15:15:26 PDT
Created attachment 439667 [details] Patch
Chris Dumez
Comment 2 2021-09-29 15:16:57 PDT
Comment on attachment 439667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439667&action=review > Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h:53 > return WebCore::ExceptionCode::UnknownError; I think we usually: break; instead of return here. > Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h:56 > + ASSERT_NOT_REACHED(); And then not have ASSERT_NOT_REACHED() here.
Sihui Liu
Comment 3 2021-09-29 15:22:16 PDT
Created attachment 439668 [details] Patch
EWS
Comment 4 2021-09-29 16:32:02 PDT
Committed r283280 (242307@main): <https://commits.webkit.org/242307@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439668 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-29 16:33:52 PDT
<rdar://problem/83694342>
Note You need to log in before you can comment on or make changes to this bug.