Bug 230985

Summary: Make sandbox rules for debug syscalls stricter
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Per Arne Vollan 2021-09-29 14:19:11 PDT 
Make sandbox rules for debug syscalls stricter in the WebContent process on macOS and iOS.
Comment 1 Per Arne Vollan 2021-09-29 14:19:35 PDT 
<rdar://49531420>
Comment 2 Per Arne Vollan 2021-09-29 14:24:23 PDT 
Created attachment 439659 [details]
Patch
Comment 3 Brent Fulgham 2021-09-29 14:37:46 PDT 
Comment on attachment 439659 [details]
Patch

Nice! r=me
Comment 4 Per Arne Vollan 2021-09-29 15:54:13 PDT 
Comment on attachment 439659 [details]
Patch

Thanks for reviewing!
Comment 5 Per Arne Vollan 2021-09-29 16:40:34 PDT 
Created attachment 439680 [details]
Patch
Comment 6 Per Arne Vollan 2021-10-01 06:56:47 PDT 
Created attachment 439853 [details]
Patch
Comment 7 EWS 2021-10-01 10:08:01 PDT 
Committed r283375 (242383@main): <https://commits.webkit.org/242383@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439853 [details].
Comment 8 Alexey Proskuryakov 2021-10-01 10:49:28 PDT 
Comment on attachment 439853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439853&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:1333
> +(with-filter (system-attribute apple-internal)

What are the consequences of this? Will dtrace and Instruments still work with WebKit?
Comment 9 Per Arne Vollan 2021-10-01 13:59:55 PDT 
(In reply to Alexey Proskuryakov from comment #8)
> Comment on attachment 439853 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439853&action=review
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:1333
> > +(with-filter (system-attribute apple-internal)
> 
> What are the consequences of this? Will dtrace and Instruments still work
> with WebKit?

That is a good point. I will look into confirming that.

Thanks for reviewing!