Bug 230978

Summary: Clean up PrivateClickMeasurement
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2021-09-29 12:50:33 PDT
Clean up PrivateClickMeasurement
Attachments
Patch (40.39 KB, patch)
2021-09-29 12:59 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (42.99 KB, patch)
2021-09-29 14:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-09-29 12:59:39 PDT
Created attachment 439646 [details] Patch
Kate Cheney
Comment 2 2021-09-29 13:34:27 PDT
Comment on attachment 439646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439646&action=review > Source/WebCore/loader/PrivateClickMeasurement.h:59 > + static constexpr uint8_t MaxEntropy = 255; This value is probably not needed anymore because you don't need to check validity of SourceID. > Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2653 > + return adoptNS([[UIEventAttribution alloc] initWithSourceIdentifier:measurement->sourceID().id destinationURL:destinationURL sourceDescription:nil purchaser:nil]).autorelease(); this doesn't seem correct.
Alex Christensen
Comment 3 2021-09-29 14:49:04 PDT
Created attachment 439663 [details] Patch
EWS
Comment 4 2021-09-30 08:42:38 PDT
Committed r283313 (242338@main): <https://commits.webkit.org/242338@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439663 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-30 08:43:16 PDT
<rdar://problem/83721099>
Note You need to log in before you can comment on or make changes to this bug.