Bug 230978

Summary:

Clean up PrivateClickMeasurement

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, katherine_cheney, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2021-09-29 12:50:33 PDT

Clean up PrivateClickMeasurement

Comment 1 Alex Christensen 2021-09-29 12:59:39 PDT

Created attachment 439646 [details]
Patch

Comment 2 Kate Cheney 2021-09-29 13:34:27 PDT

Comment on attachment 439646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439646&action=review

> Source/WebCore/loader/PrivateClickMeasurement.h:59
> +        static constexpr uint8_t MaxEntropy = 255;

This value is probably not needed anymore because you don't need to check validity of SourceID.

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2653
> +    return adoptNS([[UIEventAttribution alloc] initWithSourceIdentifier:measurement->sourceID().id destinationURL:destinationURL sourceDescription:nil purchaser:nil]).autorelease();

this doesn't seem correct.

Comment 3 Alex Christensen 2021-09-29 14:49:04 PDT

Created attachment 439663 [details]
Patch

Comment 4 EWS 2021-09-30 08:42:38 PDT

Committed r283313 (242338@main): <https://commits.webkit.org/242338@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439663 [details].

Comment 5 Radar WebKit Bug Importer 2021-09-30 08:43:16 PDT

<rdar://problem/83721099>