Bug 230966

Summary: GC may not know about memory used by AudioBufferSourceNode's buffer
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, mark.lam, philipj, saam, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230950
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Chris Dumez 2021-09-29 10:37:03 PDT 
Have AudioBufferSourceNode report its buffer's memory for GC purposes, unless its buffer still has a JS wrapper (which already does report this memory).
Comment 1 Chris Dumez 2021-09-29 10:39:11 PDT 
Created attachment 439623 [details]
Patch
Comment 2 Chris Dumez 2021-09-30 08:39:41 PDT 
Created attachment 439740 [details]
Patch
Comment 3 Chris Dumez 2021-09-30 09:19:57 PDT 
Created attachment 439743 [details]
Patch
Comment 4 Darin Adler 2021-10-01 13:03:41 PDT 
Comment on attachment 439743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439743&action=review

> Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:40
> +    visitor.addOpaqueRoot(wrapped().buffer());

I think this needs a comment. Normally we mark things so we can preserve custom JavaScript property values on the wrapper, not so that garbage collection understands memory use. So this is needed for a subtle reason that someone might not understand.
Comment 5 Chris Dumez 2021-10-01 13:07:31 PDT 
Created attachment 439900 [details]
Patch
Comment 6 EWS 2021-10-01 14:24:44 PDT 
Committed r283402 (242405@main): <https://commits.webkit.org/242405@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439900 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-01 14:25:19 PDT 
<rdar://problem/83782206>