Bug 230966

Summary: GC may not know about memory used by AudioBufferSourceNode's buffer
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, mark.lam, philipj, saam, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230950
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Chris Dumez
Reported 2021-09-29 10:37:03 PDT
Have AudioBufferSourceNode report its buffer's memory for GC purposes, unless its buffer still has a JS wrapper (which already does report this memory).
Attachments
Patch (3.04 KB, patch)
2021-09-29 10:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.12 KB, patch)
2021-09-30 08:39 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.15 KB, patch)
2021-09-30 09:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.46 KB, patch)
2021-10-01 13:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-09-29 10:39:11 PDT
Created attachment 439623 [details] Patch
Chris Dumez
Comment 2 2021-09-30 08:39:41 PDT
Created attachment 439740 [details] Patch
Chris Dumez
Comment 3 2021-09-30 09:19:57 PDT
Created attachment 439743 [details] Patch
Darin Adler
Comment 4 2021-10-01 13:03:41 PDT
Comment on attachment 439743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439743&action=review > Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:40 > + visitor.addOpaqueRoot(wrapped().buffer()); I think this needs a comment. Normally we mark things so we can preserve custom JavaScript property values on the wrapper, not so that garbage collection understands memory use. So this is needed for a subtle reason that someone might not understand.
Chris Dumez
Comment 5 2021-10-01 13:07:31 PDT
Created attachment 439900 [details] Patch
EWS
Comment 6 2021-10-01 14:24:44 PDT
Committed r283402 (242405@main): <https://commits.webkit.org/242405@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439900 [details].
Radar WebKit Bug Importer
Comment 7 2021-10-01 14:25:19 PDT
<rdar://problem/83782206>
Note You need to log in before you can comment on or make changes to this bug.