Bug 230957 – [JSC] Add objectTypeCounts to JSGetMemoryUsageStatistics

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Basuke Suzuki]

It is very useful to have the numbers of each object types in the JS statistics.

[Basuke Suzuki]

Created attachment 439639 [details]
PATCH

[Basuke Suzuki]

Added memoryUsageStatistics() to jsc.

Input:

function dump(values, indent = '') {
    for (const key in values) {
        const value = values[key];
        if (typeof value === 'object') {
            print(`${indent}${key}:`);
            dump(value, indent + '  ');
        } else
            print(`${indent}${key}: ${value}`);
    }
}
dump(memoryUsageStatistics());

Output:

heapSize: 0
heapCapacity: 344064
extraMemorySize: 0
objectCount: 0
protectedObjectCount: 44
protectedGlobalObjectCount: 0
objectTypeCounts:
  JSProxy: 1
  Promise: 1
  Callee: 2
  Atomics: 1
...

[Yusuke Suzuki]

Comment on attachment 439639 [details]
PATCH

I think this is fine. r=me

[Ross Kirsling]

Comment on attachment 439639 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=439639&action=review

> Source/JavaScriptCore/API/JSBase.cpp:208
> +    JSObject* objectTypeCounts = constructEmptyObject(globalObject);

I think you could do `constructEmptyObject(vm, globalObject->nullPrototypeObjectStructure())` since this object is just holding key-value pairs and doesn't need access to the Object prototype.

> Source/JavaScriptCore/API/JSBasePrivate.h:74
> + objectTypeCounts: object which has kind as key and its number as value for each GC objects 

I think something like "object with HeapCell kinds as keys and their current counts as values" would be clearer.

[Basuke Suzuki]

Created attachment 439672 [details]
PATCH

[Basuke Suzuki]

Thanks Ross.

[EWS]

Committed r283286 (242313@main): <https://commits.webkit.org/242313@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439672 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83696026>