Bug 230936

Summary:	webkitpy-tests-python3 is randomly failing on EWS : TypeError: __call__() got an unexpected keyword argument 'warn_on_impl'
Product:	WebKit	Reporter:	Fujii Hironori <Hironori.Fujii>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	ap, jbedard
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Fujii Hironori 2021-09-28 23:45:37 PDT

webkitpy-tests-python3 is randomly failing on EWS : TypeError: __call__() got an unexpected keyword argument 'warn_on_impl'

https://ews-build.webkit.org/#/builders/5/builds/61343
https://ews-build.webkit.org/#/builders/5/builds/61274
https://ews-build.webkit.org/#/builders/5/builds/61257
https://ews-build.webkit.org/#/builders/5/builds/61147


Checking imports ...
Traceback (most recent call last):
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/webkitpy/test/main.py", line 356, in <module>
    sys.exit(main())
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/webkitpy/test/main.py", line 111, in main
    return not tester.run()
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/webkitpy/test/main.py", line 184, in run
    return self._run_tests(names)
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/webkitpy/test/main.py", line 207, in _run_tests
    if not self._check_imports(names):
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/webkitpy/test/main.py", line 290, in _check_imports
    __import__(name)
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/webkitpy/common/config/committers_unittest.py", line 31, in <module>
    from webkitpy.test.markers import xfail
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/webkitpy/test/markers.py", line 26, in <module>
    import pytest
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/pytest.py", line 9, in <module>
    from _pytest.config import main, UsageError, cmdline, hookspec, hookimpl
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/_pytest/config/__init__.py", line 39, in <module>
    import _pytest.hookspec
  File "/Volumes/Data/worker/WebKitPy-Tests-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/_pytest/hookspec.py", line 744, in <module>
    @hookspec(historic=True, warn_on_impl=WARNING_CAPTURED_HOOK)
TypeError: __call__() got an unexpected keyword argument 'warn_on_impl'

Comment 1 Jonathan Bedard 2021-09-29 07:40:52 PDT

I fixed the webkit-misc bot (which was the one in a bad state)

The issue here is that we're caching installed libraries, so if someone posts a bad patch, it has the potential to break our cache on one of these bots. There are a few things we could do to fix it (like clearing out our autoinstalled libraries when running webkitpy tests), but I think I'd rather just deal with the occasional bot being in a bad state than the potential network issues we may encounter re-installing all our libraries every time.