Bug 230920

Summary: iOS simulator build should use PTHREAD_JIT_PERMISSIONS_API
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: Alex_fioletov, benjamin, cdumez, cmarcelo, ews-watchlist, fpizlo, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
fpizlo: review+
Patch for landing none

Yusuke Suzuki
Reported 2021-09-28 15:43:33 PDT
iOS simulator build should use PTHREAD_JIT_PERMISSIONS_API
Attachments
Patch (1.52 KB, patch)
2021-09-28 15:45 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2021-09-28 15:49 PDT, Yusuke Suzuki 		fpizlo: review+
DetailsFormatted DiffDiff
Patch for landing (1.74 KB, patch)
2021-09-28 19:54 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-09-28 15:45:47 PDT
Created attachment 439535 [details] Patch
Yusuke Suzuki
Comment 2 2021-09-28 15:45:50 PDT
<rdar://problem/77494871>
Yusuke Suzuki
Comment 3 2021-09-28 15:48:33 PDT
Comment on attachment 439535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439535&action=review > Source/WTF/wtf/PlatformUse.h:331 > + || (PLATFORM(IOS) && PLATFORM(IOS_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) PLATFORM(IOS) is not necessary. Removed.
Yusuke Suzuki
Comment 4 2021-09-28 15:49:38 PDT
Created attachment 439536 [details] Patch
Yusuke Suzuki
Comment 5 2021-09-28 16:07:23 PDT
*** Bug 228990 has been marked as a duplicate of this bug. ***
Tim Horton
Comment 6 2021-09-28 16:43:15 PDT
Do you perhaps want IOS_FAMILY_SIMULATOR? or is there something special about iOS *specifically*?
Yusuke Suzuki
Comment 7 2021-09-28 19:46:54 PDT
(In reply to Tim Horton from comment #6) > Do you perhaps want IOS_FAMILY_SIMULATOR? or is there something special > about iOS *specifically*? IOS_FAMILY_SIMULATOR is better, changed.
Yusuke Suzuki
Comment 8 2021-09-28 19:54:15 PDT
Created attachment 439559 [details] Patch for landing
Yusuke Suzuki
Comment 9 2021-09-28 23:23:40 PDT
Committed r283211 (242253@main): <https://commits.webkit.org/242253@main>
Tim Horton
Comment 10 2021-09-28 23:41:52 PDT
FWIW the final patch is a bit overkill, because we don't care about (or even successfully build on!) iOS < 14 or watchOS < 7 anymore. (I should have caught this when I said the last thing). Still, your patch is fine.
Yusuke Suzuki
Comment 11 2021-09-29 00:25:47 PDT
(In reply to Tim Horton from comment #10) > FWIW the final patch is a bit overkill, because we don't care about (or even > successfully build on!) iOS < 14 or watchOS < 7 anymore. (I should have > caught this when I said the last thing). Still, your patch is fine. Ah! I see. Thanks!!
Note You need to log in before you can comment on or make changes to this bug.