Bug 230914

Summary: PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
Product: WebKit Reporter: John Wilander <wilander>
Component: WebCore Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, gsnedders, gyuyoung.kim, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

John Wilander
Reported 2021-09-28 14:21:06 PDT
We should change Private Click Measurement's anchor attributes from all lowercase to camelcase to match the spec and align with the Attribution Reporting API proposal.
Attachments
Patch (7.12 KB, patch)
2021-09-28 15:19 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-28 14:21:34 PDT
<rdar://problem/83639923>
John Wilander
Comment 2 2021-09-28 15:19:09 PDT
Created attachment 439529 [details] Patch
Sam Sneddon [:gsnedders]
Comment 3 2021-09-30 11:40:26 PDT
Non-reviewer r+. That said, I've some slight concern about breakage here, though looking on GitHub doesn't immediately show up usage of the DOM APIs.
Brent Fulgham
Comment 4 2021-09-30 15:02:55 PDT
Comment on attachment 439529 [details] Patch r=me
John Wilander
Comment 5 2021-09-30 15:14:20 PDT
Comment on attachment 439529 [details] Patch Thanks, Sam and Brent!
EWS
Comment 6 2021-09-30 15:42:25 PDT
Committed r283342 (242358@main): <https://commits.webkit.org/242358@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439529 [details].
Note You need to log in before you can comment on or make changes to this bug.