Bug 230914

Summary: PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
Product: WebKit Reporter: John Wilander <wilander>
Component: WebCore Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, gsnedders, gyuyoung.kim, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description John Wilander 2021-09-28 14:21:06 PDT 
We should change Private Click Measurement's anchor attributes from all lowercase to camelcase to match the spec and align with the Attribution Reporting API proposal.
Comment 1 Radar WebKit Bug Importer 2021-09-28 14:21:34 PDT 
<rdar://problem/83639923>
Comment 2 John Wilander 2021-09-28 15:19:09 PDT 
Created attachment 439529 [details]
Patch
Comment 3 Sam Sneddon [:gsnedders] 2021-09-30 11:40:26 PDT 
Non-reviewer r+.

That said, I've some slight concern about breakage here, though looking on GitHub doesn't immediately show up usage of the DOM APIs.
Comment 4 Brent Fulgham 2021-09-30 15:02:55 PDT 
Comment on attachment 439529 [details]
Patch

r=me
Comment 5 John Wilander 2021-09-30 15:14:20 PDT 
Comment on attachment 439529 [details]
Patch

Thanks, Sam and Brent!
Comment 6 EWS 2021-09-30 15:42:25 PDT 
Committed r283342 (242358@main): <https://commits.webkit.org/242358@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439529 [details].