| Summary: | [WTF] Add ApproximateTime | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, ews-watchlist, fpizlo, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2021-09-27 18:54:29 PDT
Created attachment 439427 [details]
Patch
Comment on attachment 439427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439427&action=review > Source/WTF/wtf/ApproximateTime.h:38 > +class ApproximateTime final { Any reason why you didn't use the mixin approach that I had in my patch? Comment on attachment 439427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439427&action=review I personally like ApproximateTime since that name shows the most error-prone thing related to this type: if we need non approximate time, then we should not use it. >> Source/WTF/wtf/ApproximateTime.h:38 >> +class ApproximateTime final { > > Any reason why you didn't use the mixin approach that I had in my patch? Sounds good! Changed. Committed r283161 (242209@main): <https://commits.webkit.org/242209@main> Committed r283163 (242211@main): <https://commits.webkit.org/242211@main> |