Bug 230876

Summary: [WTF] Add ApproximateTime
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, ews-watchlist, fpizlo, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Yusuke Suzuki
Reported 2021-09-27 18:54:29 PDT
[WTF] Add ApproximateTime
Attachments
Patch (35.01 KB, patch)
2021-09-27 19:43 PDT, Yusuke Suzuki 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-09-27 19:43:20 PDT
Created attachment 439427 [details] Patch
Filip Pizlo
Comment 2 2021-09-27 20:12:18 PDT
Comment on attachment 439427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439427&action=review > Source/WTF/wtf/ApproximateTime.h:38 > +class ApproximateTime final { Any reason why you didn't use the mixin approach that I had in my patch?
Yusuke Suzuki
Comment 3 2021-09-28 02:44:03 PDT
Comment on attachment 439427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439427&action=review I personally like ApproximateTime since that name shows the most error-prone thing related to this type: if we need non approximate time, then we should not use it. >> Source/WTF/wtf/ApproximateTime.h:38 >> +class ApproximateTime final { > > Any reason why you didn't use the mixin approach that I had in my patch? Sounds good! Changed.
Yusuke Suzuki
Comment 4 2021-09-28 02:50:03 PDT
Committed r283161 (242209@main): <https://commits.webkit.org/242209@main>
Radar WebKit Bug Importer
Comment 5 2021-09-28 02:51:16 PDT
<rdar://problem/83614252>
Yusuke Suzuki
Comment 6 2021-09-28 03:30:06 PDT
Committed r283163 (242211@main): <https://commits.webkit.org/242211@main>
Note You need to log in before you can comment on or make changes to this bug.