Bug 230853

Summary: Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, changseok, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, jean-yves.avenard, kangil.han, kondapallykalyan, macpherson, menard, mifenton, mkwst, pdr, peng.liu6, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2021-09-27 12:24:31 PDT
Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h
Attachments
Patch (68.34 KB, patch)
2021-09-27 12:33 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (79.66 KB, patch)
2021-09-27 15:29 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (80.79 KB, patch)
2021-09-27 16:04 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (80.65 KB, patch)
2021-09-27 16:46 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (81.64 KB, patch)
2021-09-28 11:16 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (83.23 KB, patch)
2021-09-28 15:06 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (82.71 KB, patch)
2021-09-29 09:28 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (82.72 KB, patch)
2021-09-29 10:34 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-09-27 12:33:18 PDT
Created attachment 439379 [details] Patch
Jer Noble
Comment 2 2021-09-27 15:29:06 PDT
Created attachment 439401 [details] Patch
Eric Carlson
Comment 3 2021-09-27 15:58:29 PDT
Comment on attachment 439401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439401&action=review r=me once the bots are happy > Source/WebCore/ChangeLog:73 > + * html/track/VideoTrackClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp. Nit: you should probably remove the auto-generated "Copied from Source/WebCore/Modules..." message as it isn't helpful. > Source/WebCore/ChangeLog:85 > + * platform/graphics/AudioTrackPrivateClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp. Ditto. > Source/WebCore/ChangeLog:94 > + * platform/graphics/TrackPrivateBaseClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp. Ditto. > Source/WebCore/ChangeLog:98 > + * platform/graphics/VideoTrackPrivateClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp. Ditto.
Jer Noble
Comment 4 2021-09-27 16:04:32 PDT
Created attachment 439408 [details] Patch
Jer Noble
Comment 5 2021-09-27 16:46:20 PDT
Created attachment 439417 [details] Patch
Jer Noble
Comment 6 2021-09-28 11:16:39 PDT
Created attachment 439497 [details] Patch Reverted the change to RefPtr, as other compilers still throw errors for "RefPtr<Foo> foo() { return nullptr ; }" when Foo is forward-declared.
Jer Noble
Comment 7 2021-09-28 15:06:39 PDT
Created attachment 439527 [details] Patch
Jer Noble
Comment 8 2021-09-29 09:28:24 PDT
Created attachment 439613 [details] Patch for landing
EWS
Comment 9 2021-09-29 09:29:22 PDT
Tools/Scripts/svn-apply failed to apply attachment 439613 [details] to trunk. Please resolve the conflicts and upload a new patch.
Jer Noble
Comment 10 2021-09-29 10:34:15 PDT
Created attachment 439622 [details] Patch for landing
EWS
Comment 11 2021-09-29 11:19:55 PDT
Committed r283237 (242279@main): <https://commits.webkit.org/242279@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439622 [details].
Radar WebKit Bug Importer
Comment 12 2021-09-29 11:20:24 PDT
<rdar://problem/83680121>
Note You need to log in before you can comment on or make changes to this bug.