| Summary: | Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||||
| Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | annulen, benjamin, calvaris, cdumez, changseok, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, jean-yves.avenard, kangil.han, kondapallykalyan, macpherson, menard, mifenton, mkwst, pdr, peng.liu6, philipj, ryuan.choi, sergio, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Jer Noble
2021-09-27 12:24:31 PDT
Created attachment 439379 [details]
Patch
Created attachment 439401 [details]
Patch
Comment on attachment 439401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439401&action=review r=me once the bots are happy > Source/WebCore/ChangeLog:73 > + * html/track/VideoTrackClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp. Nit: you should probably remove the auto-generated "Copied from Source/WebCore/Modules..." message as it isn't helpful. > Source/WebCore/ChangeLog:85 > + * platform/graphics/AudioTrackPrivateClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp. Ditto. > Source/WebCore/ChangeLog:94 > + * platform/graphics/TrackPrivateBaseClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp. Ditto. > Source/WebCore/ChangeLog:98 > + * platform/graphics/VideoTrackPrivateClient.h: Copied from Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp. Ditto. Created attachment 439408 [details]
Patch
Created attachment 439417 [details]
Patch
Created attachment 439497 [details]
Patch
Reverted the change to RefPtr, as other compilers still throw errors for "RefPtr<Foo> foo() { return nullptr ; }" when Foo is forward-declared.
Created attachment 439527 [details]
Patch
Created attachment 439613 [details]
Patch for landing
Tools/Scripts/svn-apply failed to apply attachment 439613 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 439622 [details]
Patch for landing
Committed r283237 (242279@main): <https://commits.webkit.org/242279@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439622 [details]. |