Summary: | REGRESSION (r283102): [ MacOS Debug ] TestWebKitAPI.WebKit2.CaptureIndicatorDelay is failing | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ayumi_kojima | ||||||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | saam, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf, ysuzuki | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Mac (Intel) | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=229223 | ||||||||||||
Attachments: |
|
Description
ayumi_kojima
2021-09-27 09:39:13 PDT
According to the history, the test started failing at https://trac.webkit.org/changeset/283102/webkit This change was reverted again. *** This bug has been marked as a duplicate of bug 230854 *** Relanding unlinked baseline. Need to figure this out I think my patch just perturbed a pre-existing race. Created attachment 439421 [details]
patch
Comment on attachment 439421 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=439421&action=review > Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:398 > + [webView stringByEvaluatingJavaScript:@"setTimeout(stop, 0)"]; I think this might still be racy, at least in theory. Let's make it bullet proof by waiting for getUserMedia promise resolution to actually call stop. Created attachment 439439 [details]
Patch
Created attachment 439463 [details]
Patch
Created attachment 439470 [details]
Patch
Committed r283172 (242220@main): <https://commits.webkit.org/242220@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439470 [details]. |