Bug 230820

Summary: Remove ImplicitAddress
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, mmaxfield, msaboff, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test EWS
ews-feeder: commit-queue-
test EWS
ews-feeder: commit-queue-
test EWS
none
patch none

Description Saam Barati 2021-09-27 00:47:16 PDT 
See what a gigantic waste of time I experienced in https://bugs.webkit.org/show_bug.cgi?id=229223 because of MSVC coercing regT0 to be nullptr instead of invoking the ImplicitAddress version of a function. We should just use Address(RegisterID) instead of relying on ImplicitAddress so we don't feel this pain in the future.
Comment 1 Radar WebKit Bug Importer 2021-10-04 00:48:20 PDT 
<rdar://problem/83826318>
Comment 2 Saam Barati 2021-10-11 16:45:20 PDT 
Created attachment 440859 [details]
test EWS
Comment 3 Saam Barati 2021-10-11 17:00:32 PDT 
Created attachment 440860 [details]
test EWS
Comment 4 Saam Barati 2021-10-11 17:09:23 PDT 
Created attachment 440863 [details]
test EWS
Comment 5 Saam Barati 2021-10-11 18:55:38 PDT 
Created attachment 440868 [details]
patch
Comment 6 Yusuke Suzuki 2021-10-11 18:57:45 PDT 
Comment on attachment 440868 [details]
patch

r=me if EWS is green.
Comment 7 EWS 2021-10-11 23:33:04 PDT 
Committed r283970 (242817@main): <https://commits.webkit.org/242817@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440868 [details].
Comment 8 Myles C. Maxfield 2021-10-12 01:02:55 PDT Comment hidden (obsolete)