Bug 230820

Summary:

Remove ImplicitAddress

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, mmaxfield, msaboff, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
test EWS	ews-feeder: commit-queue-
test EWS	ews-feeder: commit-queue-
test EWS	none
patch	none

Saam Barati

Reported 2021-09-27 00:47:16 PDT

See what a gigantic waste of time I experienced in https://bugs.webkit.org/show_bug.cgi?id=229223 because of MSVC coercing regT0 to be nullptr instead of invoking the ImplicitAddress version of a function. We should just use Address(RegisterID) instead of relying on ImplicitAddress so we don't feel this pain in the future.

Attachments
test EWS (62.79 KB, patch) 2021-10-11 16:45 PDT, Saam Barati	ews-feeder: commit-queue-	Details Formatted Diff Diff
test EWS (65.36 KB, patch) 2021-10-11 17:00 PDT, Saam Barati	ews-feeder: commit-queue-	Details Formatted Diff Diff
test EWS (66.39 KB, patch) 2021-10-11 17:09 PDT, Saam Barati	no flags	Details Formatted Diff Diff
patch (67.66 KB, patch) 2021-10-11 18:55 PDT, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.