Summary: | [Curl] Set CURL_LOCK_DATA_SSL_SESSION option to reduce SSL/TLS handshake time | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Takashi Komori <takashi.komori> | ||||||
Component: | Platform | Assignee: | Takashi Komori <takashi.komori> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | Basuke.Suzuki, chris.reid, don.olmstead, ews-watchlist, galpeter, Hironori.Fujii, ross.kirsling, stephan.szabo, takashi.komori, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Takashi Komori
2021-09-26 23:16:26 PDT
Created attachment 439320 [details]
Patch
Comment on attachment 439320 [details]
Patch
LGTM
Committed r283136 (242193@main): <https://commits.webkit.org/242193@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439320 [details]. WinCairo-64-bit-WKL-Debug-Tests is crashing. Reopened. https://build.webkit.org/#/builders/32/builds/1031 SHOULD NEVER BE REACHED ..\..\Source\WebCore\platform\network\curl\CurlContext.cpp(211) : WebCore::CurlShareHandle::mutexFor Regressions: Unexpected crashes (34) http/tests/IndexedDB/collect-IDB-objects.https.html [ Crash ] http/tests/IndexedDB/storage-limit-1.https.html [ Crash ] http/tests/IndexedDB/storage-limit-2.https.html [ Crash ] http/tests/IndexedDB/storage-limit.https.html [ Crash ] http/tests/eventloop/documents-with-different-protocols-do-not-share-event-loop.html [ Crash ] http/tests/misc/dns-prefetch-control.html [ Crash ] http/tests/misc/webtiming-ssl.py [ Crash ] [...] Committed r283166 (242214@main): <https://commits.webkit.org/242214@main> Reverted. Reopened. Created attachment 439514 [details]
Patch
(In reply to Fujii Hironori from comment #5) > WinCairo-64-bit-WKL-Debug-Tests is crashing. Reopened. > > https://build.webkit.org/#/builders/32/builds/1031 > > SHOULD NEVER BE REACHED > ..\..\Source\WebCore\platform\network\curl\CurlContext.cpp(211) : > WebCore::CurlShareHandle::mutexFor > > Regressions: Unexpected crashes (34) > http/tests/IndexedDB/collect-IDB-objects.https.html [ Crash ] > http/tests/IndexedDB/storage-limit-1.https.html [ Crash ] > http/tests/IndexedDB/storage-limit-2.https.html [ Crash ] > http/tests/IndexedDB/storage-limit.https.html [ Crash ] > > http/tests/eventloop/documents-with-different-protocols-do-not-share-event- > loop.html [ Crash ] > http/tests/misc/dns-prefetch-control.html [ Crash ] > http/tests/misc/webtiming-ssl.py [ Crash ] > [...] The cause of the crash was that we didn't have code for exclusive control for shared SSL session. We fixed it. Comment on attachment 439514 [details] Patch Clearing flags on attachment: 439514 Committed r283208 (242250@main): <https://commits.webkit.org/242250@main> All reviewed patches have been landed. Closing bug. |