Bug 230816

Summary: prepare-ChangeLog does not show the correct result with using --git-commit
Product: WebKit Reporter: Hoa Dinh <dvh>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Hoa Dinh
Reported 2021-09-26 21:35:40 PDT
After deleting some function in a commit, using the following command won't show the deleted functions in the list of modified functions. $ prepare-ChangeLog --no-write --no-style --only-files -g HEAD The cause of the bug is that the originalFile() function will pick the incorrect reference version of the file to compare with the version of the commit.
Attachments
Patch (1.48 KB, patch)
2021-09-26 21:40 PDT, Hoa Dinh 		no flags
DetailsFormatted DiffDiff
Patch (2.23 KB, patch)
2021-09-26 22:33 PDT, Hoa Dinh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hoa Dinh
Comment 1 2021-09-26 21:40:19 PDT
Created attachment 439313 [details] Patch
Hoa Dinh
Comment 2 2021-09-26 22:33:30 PDT
Created attachment 439317 [details] Patch
EWS
Comment 3 2021-09-27 08:50:56 PDT
Committed r283112 (242170@main): <https://commits.webkit.org/242170@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439317 [details].
Radar WebKit Bug Importer
Comment 4 2021-09-27 08:51:16 PDT
<rdar://problem/83575118>
youenn fablet
Comment 5 2021-10-05 03:36:29 PDT
When doing Tools/Scripts/prepare-ChangeLog -g HEAD~1..HEAD -b XYZ, I now get some errors like: Use of uninitialized value $first_line in pattern match (m//) at Tools/Scripts/prepare-ChangeLog line 783. Reverting the commit removes the error.
Note You need to log in before you can comment on or make changes to this bug.