Bug 230790

Summary: Font palette names have to start with two hyphens
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230446    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch dino: review+

Description Myles C. Maxfield 2021-09-25 03:14:03 PDT 
Font palette names have to start with two hyphens
Comment 1 Myles C. Maxfield 2021-09-25 03:18:34 PDT 
Created attachment 439253 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-09-25 03:19:07 PDT 
<rdar://problem/83530013>
Comment 3 EWS Watchlist 2021-09-25 03:20:00 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Myles C. Maxfield 2021-09-25 03:37:59 PDT 
Created attachment 439255 [details]
Patch
Comment 5 Myles C. Maxfield 2021-09-27 12:55:41 PDT 
Comment on attachment 439255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439255&action=review

> Source/WebCore/css/parser/CSSParserImpl.cpp:662
> +    auto name = CSSPropertyParserHelpers::consumeDashedCustomIdent(prelude);

This is not a good name.
Comment 6 Myles C. Maxfield 2021-09-27 23:05:06 PDT 
Created attachment 439435 [details]
Patch
Comment 7 Myles C. Maxfield 2021-09-28 01:28:11 PDT 
Created attachment 439443 [details]
Patch
Comment 8 Myles C. Maxfield 2021-09-28 14:14:25 PDT 
Created attachment 439515 [details]
Patch
Comment 9 Myles C. Maxfield 2021-09-29 08:41:04 PDT 
Committed r283221 (242263@main): <https://commits.webkit.org/242263@main>