Bug 230771

Summary: Enable CFPrefs direct mode in all WebKit processes
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, gavin.p, ggaren, jiewen_tan, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch
none
Patch none

Per Arne Vollan
Reported 2021-09-24 13:56:05 PDT
We currently enable CFPrefs direct mode in the WebContent and GPU Process, and we should enable it in all WebKit processes.
Attachments
Patch (8.38 KB, patch)
2021-09-24 14:49 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (8.29 KB, patch)
2021-09-24 14:52 PDT, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (11.26 KB, patch)
2021-09-27 12:40 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (12.78 KB, patch)
2021-09-28 08:49 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-24 13:56:44 PDT
<rdar://problem/83510055>
Per Arne Vollan
Comment 2 2021-09-24 14:49:39 PDT
Created attachment 439199 [details] Patch
Per Arne Vollan
Comment 3 2021-09-24 14:52:18 PDT
Created attachment 439201 [details] Patch
Brent Fulgham
Comment 4 2021-09-27 10:53:12 PDT
Comment on attachment 439201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439201&action=review r=me. Please be sure Adam re-tests WebAuthn after this change. > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:1066 > + }); Do we need a similar message for the WebAuthn process?
Per Arne Vollan
Comment 5 2021-09-27 12:05:20 PDT
(In reply to Brent Fulgham from comment #4) > Comment on attachment 439201 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=439201&action=review > > r=me. Please be sure Adam re-tests WebAuthn after this change. > Yes, we will re-test WebAuthn. > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:1066 > > + }); > > Do we need a similar message for the WebAuthn process? That is a good point. I will update the patch. Thanks for reviewing!
Per Arne Vollan
Comment 6 2021-09-27 12:40:43 PDT
Created attachment 439381 [details] Patch
Per Arne Vollan
Comment 7 2021-09-28 08:49:26 PDT
Created attachment 439480 [details] Patch
EWS
Comment 8 2021-09-28 11:06:47 PDT
Committed r283183 (242231@main): <https://commits.webkit.org/242231@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439480 [details].
Note You need to log in before you can comment on or make changes to this bug.