Bug 230761

Summary: [Media Controls] Allow for a close button
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ehutchison, eric.carlson, ews-watchlist, glenn, hi, jer.noble, joepeck, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Antoine Quint
Reported 2021-09-24 10:59:10 PDT
[Media Controls] Allow for a close button
Attachments
Patch (32.91 KB, patch)
2021-09-24 11:00 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (16.68 KB, patch)
2021-09-24 11:19 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (17.53 KB, patch)
2021-09-24 14:24 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-09-24 11:00:53 PDT
Created attachment 439168 [details] Patch
Antoine Quint
Comment 2 2021-09-24 11:19:48 PDT
Created attachment 439174 [details] Patch
Antoine Quint
Comment 3 2021-09-24 11:44:20 PDT
Committed r283050 (242110@main): <https://commits.webkit.org/242110@main>
Radar WebKit Bug Importer
Comment 4 2021-09-24 11:45:44 PDT
<rdar://problem/83505067>
Eric Hutchison
Comment 5 2021-09-24 13:29:53 PDT
Reverted r283050 for reason: Broke commit-queue Committed r283054 (242114@main): <https://commits.webkit.org/242114@main>
Antoine Quint
Comment 6 2021-09-24 14:24:38 PDT
Created attachment 439197 [details] Patch
Devin Rousso
Comment 7 2021-09-24 14:48:01 PDT
Comment on attachment 439197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439197&action=review > Source/WebCore/Modules/modern-media-controls/media/close-support.js:38 > + this.mediaController.media.webkitExitFullscreen(); Can we not use `FullscreenButton` and `FullscreenSupport` to achieve this same behavior? Why do we need an entirely new button that is just a functional subset of an existing button with a different icon? Could we parameterize the existing button instead to just change the icon based on a `LayoutTraits` getter?
EWS
Comment 8 2021-09-24 15:35:57 PDT
Committed r283064 (242122@main): <https://commits.webkit.org/242122@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439197 [details].
Note You need to log in before you can comment on or make changes to this bug.