| Summary: | [Media Controls] Allow for a close button | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, ehutchison, eric.carlson, ews-watchlist, glenn, hi, jer.noble, joepeck, philipj, sam, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antoine Quint
2021-09-24 10:59:10 PDT
Created attachment 439168 [details]
Patch
Created attachment 439174 [details]
Patch
Committed r283050 (242110@main): <https://commits.webkit.org/242110@main> Reverted r283050 for reason: Broke commit-queue Committed r283054 (242114@main): <https://commits.webkit.org/242114@main> Created attachment 439197 [details]
Patch
Comment on attachment 439197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439197&action=review > Source/WebCore/Modules/modern-media-controls/media/close-support.js:38 > + this.mediaController.media.webkitExitFullscreen(); Can we not use `FullscreenButton` and `FullscreenSupport` to achieve this same behavior? Why do we need an entirely new button that is just a functional subset of an existing button with a different icon? Could we parameterize the existing button instead to just change the icon based on a `LayoutTraits` getter? Committed r283064 (242122@main): <https://commits.webkit.org/242122@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439197 [details]. |