Bug 230702

Summary:

api-ios tests passed (instead of crash or timeout) on buggy patch for Bug 230227

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

aakash_jain, ap, dewei_zhu, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=230227

Attachments:

Description	Flags
Back out the fix from r282849	none

Description David Kilzer (:ddkilzer) 2021-09-23 11:33:41 PDT

api-ios tests in TestWebKitAPI passed (instead of crashing) on patch for Bug 230227.

The original commit for Bug 230227 had a bug where `m_weakObserver` was not set on non-macOS platforms (including Mac Catalyst and iOS), which should have caused crashes when running api-ios tests, but did not:

  Bug 230227:  <https://bugs.webkit.org/show_bug.cgi?id=230227>
  Original commit:  <https://commits.webkit.org/changeset/282632/webkit>
  Commit to fix the bug:  <https://trac.webkit.org/changeset/282849/webkit>
  Test run missing failures:  <https://ews-build.webkit.org/#/builders/9/builds/54899>

I'm still trying to reproduce the expected failure locally, but I'm filing this to track the issue.

Comment 1 David Kilzer (:ddkilzer) 2021-09-23 11:35:54 PDT

Created attachment 439073 [details]
Back out the fix from r282849

This patch should cause crashes in api-ios tests.

Posting this to test that theory.

Comment 2 Alexey Proskuryakov 2021-09-26 14:19:25 PDT

Were you able to reproduce locally?

Comment 3 David Kilzer (:ddkilzer) 2021-09-27 15:36:00 PDT

(In reply to Alexey Proskuryakov from comment #2)
> Were you able to reproduce locally?

No, a ridiculous number of iossim tests timed out even with the bug fixed (on both Big Sur and Monterey), so I gave up trying locally.

Comment 4 Tim Horton 2021-09-27 15:47:56 PDT

(On the other hand, I know of at least 3 people who could reproduce locally, including myself :P so SOMETHING interesting is happening here... but maybe it doesn't matter)