Bug 230684

Summary: LayoutTestFinder doesn't return tests in order
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230764
Attachments:
Description Flags
Patch none

Sam Sneddon [:gsnedders]
Reported 2021-09-23 04:47:17 PDT
It is clearly intended that LayoutTestFinder returns the tests in a deterministic order. But it doesn't actually do that: top-level directories appear in an arbitrary order. Found while rewriting LayoutTestFinder and trying to compare my results against what we currently have.
Attachments
Patch (5.23 KB, patch)
2021-09-23 11:04 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-09-23 11:04:44 PDT
Created attachment 439069 [details] Patch
Alexey Proskuryakov
Comment 2 2021-09-23 17:51:44 PDT
Comment on attachment 439069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439069&action=review > Tools/ChangeLog:10 > + running run-webkit-tests with no arguments ends up running the top-level directories in a Is this a recent regression? In my experience, accessibility and animations always went first.
Sam Sneddon [:gsnedders]
Comment 3 2021-09-24 05:45:30 PDT
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 439069 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=439069&action=review > > > Tools/ChangeLog:10 > > + running run-webkit-tests with no arguments ends up running the top-level directories in a > > Is this a recent regression? In my experience, accessibility and animations > always went first. IIRC, it should in practice depend on the order the OS enumerates them (via libc).
EWS
Comment 4 2021-09-24 05:58:48 PDT
Committed r283037 (242097@main): <https://commits.webkit.org/242097@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439069 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-24 05:59:19 PDT
<rdar://problem/83493574>
Note You need to log in before you can comment on or make changes to this bug.