Summary: | [MSE] appending to the source buffer will not throw when the source buffer is full. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> | ||||||||
Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | https://jyavenard.github.io/htmltests/tests/mse_webm/sizeSourceBuffer.html | ||||||||||
Bug Depends on: | 225800 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Jean-Yves Avenard [:jya]
2021-09-23 00:56:25 PDT
Old regression: bug 166620 My bad, this is another regression from bug 225800 ; another regression was fixed by 226720 but it was not handling all cases. what we see here is because the buffered range start is 0.007 which is close to currentTime, but doesn't contain currentTime. Ideally we should have a fuzzy find that contains performs a search ignoring the gap the player will ignore. Created attachment 439147 [details]
Patch
Created attachment 439234 [details]
Patch
Add an extra test
Comment on attachment 439234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439234&action=review > Source/WebCore/platform/graphics/PlatformTimeRanges.cpp:206 > +size_t PlatformTimeRanges::findWithFudge(const MediaTime& time, const MediaTime& fudge) I know we call the factor “fudge” in MSE code, but we use “epsilon” in the rest of WebKit so I think it would be better to use that term in this class > Source/WebCore/platform/graphics/PlatformTimeRanges.cpp:216 > +PlatformTimeRanges PlatformTimeRanges::copyWithFudge(const MediaTime& fudge) const Ditto Created attachment 439302 [details]
Patch
apply comment: rename methods
Committed r283097 (242155@main): <https://commits.webkit.org/242155@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439302 [details]. |