Bug 230655

Summary: [webkitscmpy] Linkify http urls in pull-requests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-09-22 17:02:11 PDT
In GitHub pull requests, we should linkify http urls. This includes both the code to generate the pull-request and the code parsing our existing pull-requests.
Attachments
Patch (14.23 KB, patch)
2021-09-29 16:52 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.58 KB, patch)
2021-10-01 08:55 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2021-09-22 17:16:36 PDT
Pull-request: https://github.com/WebKit/WebKit/pull/10
Jonathan Bedard
Comment 2 2021-09-29 16:52:55 PDT
Created attachment 439681 [details] Patch
Radar WebKit Bug Importer
Comment 3 2021-09-29 17:03:37 PDT
<rdar://problem/83695409>
Stephanie Lewis
Comment 4 2021-09-30 17:40:44 PDT
Comment on attachment 439681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439681&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:52 > + def escape_html(cls, message): out of curiosity why not use an escape library?
Jonathan Bedard
Comment 5 2021-10-01 08:22:32 PDT
Comment on attachment 439681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439681&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:52 >> + def escape_html(cls, message): > > out of curiosity why not use an escape library? I didn't find one that did exactly what we needed, because we don't need general HTML escaping (GitHub does quite a bit of the work for us), just some very specific cases to handle string like "<rdar://problem/1234">
Jonathan Bedard
Comment 6 2021-10-01 08:55:08 PDT
Created attachment 439865 [details] Patch for landing
EWS
Comment 7 2021-10-01 09:27:31 PDT
Committed r283373 (242381@main): <https://commits.webkit.org/242381@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439865 [details].
Note You need to log in before you can comment on or make changes to this bug.