| Summary: | [webkitscmpy] Linkify http urls in pull-requests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | slewis, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2021-09-22 17:02:11 PDT
Pull-request: https://github.com/WebKit/WebKit/pull/10 Created attachment 439681 [details]
Patch
Comment on attachment 439681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439681&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:52 > + def escape_html(cls, message): out of curiosity why not use an escape library? Comment on attachment 439681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439681&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:52 >> + def escape_html(cls, message): > > out of curiosity why not use an escape library? I didn't find one that did exactly what we needed, because we don't need general HTML escaping (GitHub does quite a bit of the work for us), just some very specific cases to handle string like "<rdar://problem/1234"> Created attachment 439865 [details]
Patch for landing
Committed r283373 (242381@main): <https://commits.webkit.org/242381@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439865 [details]. |