Bug 230610

Summary: REGRESSION(r282082): [GTK] Tests timeout when using xvfb after r282082
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, ews-watchlist, glenn, jbedard, pnormand, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229758
Attachments:
Description Flags
Patch pnormand: review+

Carlos Garcia Campos
Reported 2021-09-22 04:14:22 PDT
r282082 changed the way xvfb is spawned by providing a PIPE for stdout and stderr instead of redirecting to /dev/null. The problem is that stderr is only read in case of execution failure, so when nothing fails we end up filling the buffer that is never read. We can try to find a better solution to show the stderr output in error messages, but for now we can revert that part to redirect stderr to /dev/null to make the tests work again.
Attachments
Patch (2.79 KB, patch)
2021-09-22 04:15 PDT, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-09-22 04:15:55 PDT
Created attachment 438941 [details] Patch
Carlos Garcia Campos
Comment 2 2021-09-22 04:29:09 PDT
Committed r282870 (241999@main): <https://commits.webkit.org/241999@main>
Radar WebKit Bug Importer
Comment 3 2021-09-22 04:30:17 PDT
<rdar://problem/83392739>
Note You need to log in before you can comment on or make changes to this bug.