Bug 230603 – DOMPromiseDeferred should be able to handle Ref/RefPtr resolution values for interface types

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

DOMPromiseDeferred should be able to handle Ref/RefPtr resolution values for interface types

[youenn fablet]

Created attachment 438934 [details]
Patch

[youenn fablet]

Comment on attachment 438934 [details]
Patch

win failure seems unrelated

[Sihui Liu]

Comment on attachment 438934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438934&action=review

Nice, r=me with nits.

> Source/WebCore/ChangeLog:10
> +        Small refactring to use reject instead of settle in ApplePaySetup.

refactoring

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:90
> +    Function<void(ExceptionOr<Ref<RTCCertificate>>&&)> m_resultCallback;

Do we want Function or CompletionHandler (is this function called multiple times)?
If we use Function, can we use std::exchange instead of WTFMove?

[youenn fablet]

Comment on attachment 438934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438934&action=review

>> Source/WebCore/ChangeLog:10
>> +        Small refactring to use reject instead of settle in ApplePaySetup.
> 
> refactoring

Will change

>> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:90
>> +    Function<void(ExceptionOr<Ref<RTCCertificate>>&&)> m_resultCallback;
> 
> Do we want Function or CompletionHandler (is this function called multiple times)?
> If we use Function, can we use std::exchange instead of WTFMove?

Function is fine, it will only be called once but there is no guarantee that it will always be called.
We could use exchange but, given we do not reuse RTCCertificateGeneratorCallback, it is equivalent but more verbose than WTFMove.

[youenn fablet]

Created attachment 439072 [details]
Patch for landing

[EWS]

Committed r283028 (242088@main): <https://commits.webkit.org/242088@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439072 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83483186>