Bug 230597

Summary: [LFC][Integration] Remove ensureLineBoxes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2021-09-21 22:08:02 PDT 
Remove some ensureLineBoxes
Comment 1 Antti Koivisto 2021-09-21 22:10:27 PDT 
Created attachment 438919 [details]
Patch
Comment 2 Antti Koivisto 2021-09-22 00:17:02 PDT 
Created attachment 438927 [details]
Patch
Comment 3 Antti Koivisto 2021-09-22 02:08:46 PDT 
Created attachment 438935 [details]
Patch
Comment 4 zalan 2021-09-22 06:15:29 PDT 
Comment on attachment 438935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438935&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:-3905
> -    ASSERT(didNeedLayout || ceilf(logicalHeight()) == ceilf(oldHeight));

The dreaded assert! I am not going to miss you.

> Source/WebCore/rendering/RenderBlockFlow.h:-368
> -    void ensureLineBoxes();
> -    void generateLineBoxTree();

end of an era.
Comment 5 EWS 2021-09-22 06:38:25 PDT 
Committed r282873 (242002@main): <https://commits.webkit.org/242002@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438935 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-22 06:39:19 PDT 
<rdar://problem/83398394>