Bug 230597

Summary: [LFC][Integration] Remove ensureLineBoxes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Antti Koivisto
Reported 2021-09-21 22:08:02 PDT
Remove some ensureLineBoxes
Attachments
Patch (4.93 KB, patch)
2021-09-21 22:10 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (5.92 KB, patch)
2021-09-22 00:17 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (9.96 KB, patch)
2021-09-22 02:08 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-21 22:10:27 PDT
Created attachment 438919 [details] Patch
Antti Koivisto
Comment 2 2021-09-22 00:17:02 PDT
Created attachment 438927 [details] Patch
Antti Koivisto
Comment 3 2021-09-22 02:08:46 PDT
Created attachment 438935 [details] Patch
alan
Comment 4 2021-09-22 06:15:29 PDT
Comment on attachment 438935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438935&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:-3905 > - ASSERT(didNeedLayout || ceilf(logicalHeight()) == ceilf(oldHeight)); The dreaded assert! I am not going to miss you. > Source/WebCore/rendering/RenderBlockFlow.h:-368 > - void ensureLineBoxes(); > - void generateLineBoxTree(); end of an era.
EWS
Comment 5 2021-09-22 06:38:25 PDT
Committed r282873 (242002@main): <https://commits.webkit.org/242002@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438935 [details].
Radar WebKit Bug Importer
Comment 6 2021-09-22 06:39:19 PDT
<rdar://problem/83398394>
Note You need to log in before you can comment on or make changes to this bug.