Bug 230595

Summary: Opus and Vorbis codecs aren't available on iPad.
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: iPhone / iPad   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230670
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Jean-Yves Avenard [:jya] 2021-09-21 21:21:03 PDT 
Opus and Vorbis are only available on Mac for some reasons:
`
#if !defined(ENABLE_VORBIS) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110300
#define ENABLE_VORBIS 1
#endif
`

We should allow them everywhere and let run-time detection performs its work
Comment 1 Radar WebKit Bug Importer 2021-09-21 21:21:54 PDT 
<rdar://problem/83382734>
Comment 2 Jean-Yves Avenard [:jya] 2021-09-21 22:27:33 PDT 
Created attachment 438921 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-09-21 23:16:23 PDT 
Created attachment 438924 [details]
Patch

Restrict to iOS and Mac as some required headers aren't included on other platforms
Comment 4 Jean-Yves Avenard [:jya] 2021-09-22 01:09:10 PDT 
Created attachment 438933 [details]
Patch
Comment 5 Eric Carlson 2021-09-22 08:35:39 PDT 
Comment on attachment 438933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438933&action=review

> Source/WebCore/ChangeLog:12
> +        Covered by existing tests.

Do the existing tests run on iOS? If so won't the expectations be wrong?
Comment 6 Jean-Yves Avenard [:jya] 2021-09-23 02:02:10 PDT 
(In reply to Eric Carlson from comment #5)
> Comment on attachment 438933 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438933&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        Covered by existing tests.
> 
> Do the existing tests run on iOS? If so won't the expectations be wrong?

They do not, I opened bug 230670 to enable them
Comment 7 EWS 2021-09-23 02:54:29 PDT 
Committed r282954 (242044@main): <https://commits.webkit.org/242044@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438933 [details].