Bug 230595 – Opus and Vorbis codecs aren't available on iPad.

• Component: Media
• Status: RESOLVED FIXED

[Jean-Yves Avenard [:jya]]

Opus and Vorbis are only available on Mac for some reasons:
`
#if !defined(ENABLE_VORBIS) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110300
#define ENABLE_VORBIS 1
#endif
`

We should allow them everywhere and let run-time detection performs its work

[Radar WebKit Bug Importer]

<rdar://problem/83382734>

[Jean-Yves Avenard [:jya]]

Created attachment 438921 [details]
Patch

[Jean-Yves Avenard [:jya]]

Created attachment 438924 [details]
Patch

Restrict to iOS and Mac as some required headers aren't included on other platforms

[Jean-Yves Avenard [:jya]]

Created attachment 438933 [details]
Patch

[Eric Carlson]

Comment on attachment 438933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438933&action=review

> Source/WebCore/ChangeLog:12
> +        Covered by existing tests.

Do the existing tests run on iOS? If so won't the expectations be wrong?

[Jean-Yves Avenard [:jya]]

(In reply to Eric Carlson from comment #5)
> Comment on attachment 438933 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438933&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        Covered by existing tests.
> 
> Do the existing tests run on iOS? If so won't the expectations be wrong?

They do not, I opened bug 230670 to enable them

[EWS]

Committed r282954 (242044@main): <https://commits.webkit.org/242044@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438933 [details].