Bug 23059

Summary:

Add contentsSizeChanged API to QWebFrame

Product:

WebKit

Reporter:

Adam Treat <manyoso>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

staikos

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

All

Attachments:

Description	Flags
Adds contentsSizeChanged signal to QWebFrame	none
Fixes the style and tabs	staikos: review+

Adam Treat

Reported 2008-12-31 07:34:18 PST

Hi, Currently QWebFrame sports a contentsSize getter which returns the current size of the contents handled by the frame. However, this size is constantly changing and a client application has no way of being notified of such changes other than polling. This is less than optimal. Attached you'll find a patch which adds a signal to QWebFrame so clients can be notified whenever the frame's contentsSizeChanged(...) Cheers, Adam

Attachments
Adds contentsSizeChanged signal to QWebFrame (15.08 KB, patch) 2008-12-31 07:35 PST, Adam Treat	no flags	Details Formatted Diff Diff
Fixes the style and tabs (15.11 KB, patch) 2009-01-05 13:08 PST, Adam Treat	staikos: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Treat

Comment 1 2008-12-31 07:35:47 PST

Created attachment 26336 [details] Adds contentsSizeChanged signal to QWebFrame Adds contentsSizeChanged signal to QWebFrame

George Staikos

Comment 2 2009-01-02 10:14:16 PST

I think this needs a bit more wide review, but otherwise r+ from me.

Adam Treat

Comment 3 2009-01-05 13:08:50 PST

Created attachment 26438 [details] Fixes the style and tabs

Note You need to log in before you can comment on or make changes to this bug.