Bug 230584

Summary: [WebIDL] Align property order of DOM constructors with ECMA-262 counterparts
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: BindingsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Trivial CC: achristensen, alecflett, annulen, beidson, calvaris, cdumez, changseok, clopez, darin, eric.carlson, esprehn+autocc, ews-watchlist, gyuyoung.kim, joepeck, jsbell, keith_miller, kevin_neal, kondapallykalyan, mark.lam, msaboff, philipj, ryuan.choi, saam, sam, sergio, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 228763    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Comment 1 Alexey Shvayka 2021-09-25 13:09:42 PDT 
Created attachment 439269 [details]
Patch
Comment 2 EWS Watchlist 2021-09-25 13:10:55 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Alexey Shvayka 2021-09-25 21:37:27 PDT 
Created attachment 439283 [details]
Patch

Bring back [LegacyFactoryFunctionEnabledBySetting] attribute and attempt to fix WPE build by exporting constructor's finishCreation() methods.
Comment 4 Alexey Shvayka 2021-09-26 00:25:43 PDT 
Created attachment 439291 [details]
Patch

Attempt to fix WPE build by populating TestWebCore_LIBRARIES.
Comment 5 Radar WebKit Bug Importer 2021-09-27 10:18:29 PDT 
<rdar://problem/83579181>
Comment 6 Alexey Shvayka 2021-09-27 17:47:01 PDT 
Created attachment 439420 [details]
Patch

Abolish calling into InternalFunction::finishCreation(VM&, unsigned length, const String& name) and instead merely reorder properties.
Comment 7 Alexey Shvayka 2021-09-28 05:59:15 PDT 
Created attachment 439464 [details]
Patch

Fix: don't overwrite "length" that was defined via [LegacyFactoryFunctionEnabledBySetting] attribute
Comment 8 EWS 2021-09-29 10:17:12 PDT 
Committed r283233 (242275@main): <https://commits.webkit.org/242275@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439464 [details].
Comment 9 Alexey Shvayka 2021-09-30 09:10:03 PDT 
Thank you for review, Alex!