Bug 230578

Summary: Clean up preference rules in sandboxes
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch
none
Patch
none
Patch
none
Patch none

Description Per Arne Vollan 2021-09-21 15:25:05 PDT 
We are currently duplicating many preference domains in the sandboxes after blocking cfprefsd by using CFPrefs direct mode. This should be addressed.
Comment 1 Radar WebKit Bug Importer 2021-09-21 15:25:28 PDT 
<rdar://problem/83371815>
Comment 2 Per Arne Vollan 2021-09-21 15:34:01 PDT 
Created attachment 438869 [details]
Patch
Comment 3 Per Arne Vollan 2021-09-22 10:56:19 PDT 
Created attachment 438961 [details]
Patch
Comment 4 Brent Fulgham 2021-09-23 11:56:34 PDT 
Comment on attachment 438961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438961&action=review

r=me, but please add a copyright heading to the new file.

> Source/WebKit/Shared/Sandbox/preferences.sb:1
> +(define (home-library-preferences-regex home-library-preferences-relative-regex)

This should have a copyright header.
Comment 5 Per Arne Vollan 2021-09-23 12:19:42 PDT 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 438961 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438961&action=review
> 
> r=me, but please add a copyright heading to the new file.
> 
> > Source/WebKit/Shared/Sandbox/preferences.sb:1
> > +(define (home-library-preferences-regex home-library-preferences-relative-regex)
> 
> This should have a copyright header.

Ah, yes, will fix!

Thanks for reviewing!
Comment 6 Per Arne Vollan 2021-09-24 09:28:05 PDT 
Created attachment 439154 [details]
Patch
Comment 7 Per Arne Vollan 2021-09-24 10:17:30 PDT 
Created attachment 439159 [details]
Patch
Comment 8 Per Arne Vollan 2021-09-24 10:59:36 PDT 
Created attachment 439167 [details]
Patch
Comment 9 Per Arne Vollan 2021-09-24 11:15:31 PDT 
Created attachment 439170 [details]
Patch
Comment 10 EWS 2021-09-24 14:43:33 PDT 
Committed r283058 (242116@main): <https://commits.webkit.org/242116@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439170 [details].