Summary: | Disable FTP | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||
Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Brady Eidson
2021-09-20 06:01:48 PDT
Created attachment 438665 [details]
Patch (which no changeling, still sorting that out)
(In reply to Brady Eidson from comment #1) > Created attachment 438665 [details] > Patch (which no changeling, still sorting that out) ChangeLog <--- DYAC Created attachment 438666 [details]
v2
Comment on attachment 438666 [details]
v2
Marking for review. Changelog on its way later
Created attachment 438674 [details]
v3
Created attachment 438680 [details]
v4
Comment on attachment 438680 [details] v4 View in context: https://bugs.webkit.org/attachment.cgi?id=438680&action=review r=me Seems fine. Please rename the setting before landing. EWS failure seems pre-existing. > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:424 > +FTPDisabled: I prefer settings to be nouns or affirmative phrases. That way, we can avoid the double negative of talking about when "ftp disabling is disabled". Let's call this just FTP or FTPEnabled or FTPSupport. (In reply to Geoffrey Garen from comment #7) > Comment on attachment 438680 [details] > v4 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=438680&action=review > > r=me > > Seems fine. Please rename the setting before landing. > > EWS failure seems pre-existing. > > > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:424 > > +FTPDisabled: > > I prefer settings to be nouns or affirmative phrases. That way, we can avoid > the double negative of talking about when "ftp disabling is disabled". Let's > call this just FTP or FTPEnabled or FTPSupport. The reason we made it a negative (and there's precedent for this) is because Experimental Runtime Features are supposed to start off and then become enabled. I'll ping you on Slack to followup. Created attachment 438768 [details]
PFL for EWS
Cq+'ed too early - Wanna make sure the API bots are happy Found 1 new test failure: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html (In reply to EWS from comment #11) > Found 1 new test failure: > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > location-protocol-setter-non-broken-weird.html This appears to be a legit error. Locally I'd already moved on from this patch, it'll take some time to get back to it to explore. (In reply to Brady Eidson from comment #12) > (In reply to EWS from comment #11) > > Found 1 new test failure: > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > location-protocol-setter-non-broken-weird.html > > This appears to be a legit error. > > Locally I'd already moved on from this patch, it'll take some time to get > back to it to explore. Up and running and can reproduce. Created attachment 438959 [details]
PFL for EWS #2
Committed r282881 (242010@main): <https://commits.webkit.org/242010@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438959 [details]. |