Bug 230464

Summary:

Stop using makeRef(*this) / makeRefPtr(this)

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, beidson, benjamin, berto, calvaris, cgarcia, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, galpeter, ggaren, glenn, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, msaboff, pangle, philipj, pnormand, ryuan.choi, saam, sam, sergio, tommyw, tonikitoo, toyoshim, tzagallo, vjaquez, webkit-bug-importer, yutak, zeno

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2021-09-19 11:16:14 PDT

Stop using makeRef(*this) / makeRefPtr(this) and use Ref { *this } / RefPtr { this } instead.

Attachments
Patch (628.00 KB, patch) 2021-09-19 11:20 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2021-09-19 11:20:03 PDT

Created attachment 438604 [details] Patch

EWS Watchlist

Comment 2 2021-09-19 16:19:31 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

EWS

Comment 3 2021-09-20 10:17:50 PDT

Committed r282755 (241892@main): <https://commits.webkit.org/241892@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438604 [details].

Radar WebKit Bug Importer

Comment 4 2021-09-20 10:18:25 PDT

<rdar://problem/83312240>

Note You need to log in before you can comment on or make changes to this bug.