Bug 230454

Summary:

Remove adjustForIOSCaretWhenScrolling() code

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

HTML Editing

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, dbates, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, megan_gardner, mifenton, pdr, sam, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	sam: review+, ews-feeder: commit-queue-
Patch	none

Description Simon Fraser (smfr) 2021-09-18 21:44:22 PDT

Remove adjustForIOSCaretWhenScrolling() code

Comment 1 Simon Fraser (smfr) 2021-09-18 21:47:56 PDT

Created attachment 438576 [details]
Patch

Comment 2 Simon Fraser (smfr) 2021-09-18 21:47:59 PDT

<rdar://problem/15579797>

Comment 3 Simon Fraser (smfr) 2021-09-18 22:13:05 PDT

Created attachment 438578 [details]
Patch

Comment 4 Sam Weinig 2021-09-19 09:46:14 PDT

Comment on attachment 438578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438578&action=review

> Source/WebCore/ChangeLog:12
> +        web-detectable that the scrollX for a scroller could end up as -2. And removing the code

If web detectable, it should really have a test case that changes. (Though perhaps that is why there are failing tests :) ).

Comment 5 Megan Gardner 2021-09-21 20:25:10 PDT

Created attachment 438909 [details]
Patch

Comment 6 EWS 2021-10-13 17:41:14 PDT

Committed r284138 (242958@main): <https://commits.webkit.org/242958@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438909 [details].