Bug 230454

Summary: Remove adjustForIOSCaretWhenScrolling() code
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: HTML EditingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dbates, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, megan_gardner, mifenton, pdr, sam, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
sam: review+, ews-feeder: commit-queue-
Patch none

Simon Fraser (smfr)
Reported 2021-09-18 21:44:22 PDT
Remove adjustForIOSCaretWhenScrolling() code
Attachments
Patch (10.45 KB, patch)
2021-09-18 21:47 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.50 KB, patch)
2021-09-18 22:13 PDT, Simon Fraser (smfr) 		sam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.22 KB, patch)
2021-09-21 20:25 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-09-18 21:47:56 PDT
Created attachment 438576 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-09-18 21:47:59 PDT
<rdar://problem/15579797>
Simon Fraser (smfr)
Comment 3 2021-09-18 22:13:05 PDT
Created attachment 438578 [details] Patch
Sam Weinig
Comment 4 2021-09-19 09:46:14 PDT
Comment on attachment 438578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438578&action=review > Source/WebCore/ChangeLog:12 > + web-detectable that the scrollX for a scroller could end up as -2. And removing the code If web detectable, it should really have a test case that changes. (Though perhaps that is why there are failing tests :) ).
Megan Gardner
Comment 5 2021-09-21 20:25:10 PDT
Created attachment 438909 [details] Patch
EWS
Comment 6 2021-10-13 17:41:14 PDT
Committed r284138 (242958@main): <https://commits.webkit.org/242958@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438909 [details].
Note You need to log in before you can comment on or make changes to this bug.