| Summary: | Have ScrollAnimation work in terms of offsets, not positions | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, koivisto, kondapallykalyan, mmaxfield, mrobinson, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 230465 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2021-09-18 16:16:39 PDT
Created attachment 438569 [details]
Patch
Created attachment 438577 [details]
Patch
Created attachment 438598 [details]
Patch
Comment on attachment 438598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438598&action=review > Source/WebCore/ChangeLog:8 > + Scroll positions can have negagive values in RTL content. It's simpler for ScrollAnimation negagive Comment on attachment 438598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438598&action=review > Source/WebCore/platform/ScrollAnimationSmooth.cpp:76 > -bool ScrollAnimationSmooth::startAnimatedScrollToDestination(const FloatPoint& fromPosition, const FloatPoint& destinationPosition) > +bool ScrollAnimationSmooth::startAnimatedScrollToDestination(const FloatPoint& fromOffset, const FloatPoint& destinationOffset) I think the difference between "position" and "offset" here is too subtle and just changing names doesn't really make things clear. It would be nice to capture it to a type. |