Bug 230450

Summary: Have ScrollAnimation work in terms of offsets, not positions
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, koivisto, kondapallykalyan, mmaxfield, mrobinson, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230465    
Attachments:
Description Flags
Patch
none
Patch
none
Patch koivisto: review+

Simon Fraser (smfr)
Reported 2021-09-18 16:16:39 PDT
Have ScrollAnimation work in terms of offsets, not positions
Attachments
Patch (31.57 KB, patch)
2021-09-18 16:19 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (32.44 KB, patch)
2021-09-18 21:57 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (32.49 KB, patch)
2021-09-19 10:10 PDT, Simon Fraser (smfr) 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-09-18 16:19:59 PDT
Created attachment 438569 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-09-18 21:57:36 PDT
Created attachment 438577 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-09-19 10:10:43 PDT
Created attachment 438598 [details] Patch
Myles C. Maxfield
Comment 4 2021-09-19 11:52:18 PDT
Comment on attachment 438598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438598&action=review > Source/WebCore/ChangeLog:8 > + Scroll positions can have negagive values in RTL content. It's simpler for ScrollAnimation negagive
Antti Koivisto
Comment 5 2021-09-19 12:19:42 PDT
Comment on attachment 438598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438598&action=review > Source/WebCore/platform/ScrollAnimationSmooth.cpp:76 > -bool ScrollAnimationSmooth::startAnimatedScrollToDestination(const FloatPoint& fromPosition, const FloatPoint& destinationPosition) > +bool ScrollAnimationSmooth::startAnimatedScrollToDestination(const FloatPoint& fromOffset, const FloatPoint& destinationOffset) I think the difference between "position" and "offset" here is too subtle and just changing names doesn't really make things clear. It would be nice to capture it to a type.
Simon Fraser (smfr)
Comment 6 2021-09-19 18:16:06 PDT
https://trac.webkit.org/changeset/282741/webkit
Radar WebKit Bug Importer
Comment 7 2021-09-19 18:17:15 PDT
<rdar://problem/83289902>
Note You need to log in before you can comment on or make changes to this bug.