Bug 23043

Summary:

Internal css for unused features should not be included

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	darin: review+

Description Eric Carlson 2008-12-30 14:13:01 PST

CSS for the optional WML, SGV and VIDEO features is in static data even when the feature is not enabled. The WML and SVG data isn't parsed and rules aren't added if the feature is not enabled, but the media controller css is in html4.css so it is always parsed and added. 

Media controls css should be split into a separate file and only parsed and added when the feature is enabled. Data for WML, SGV and VIDEO should not be included in UserAgentStyleSheetsData.cpp unless the feature is enabled.

Comment 1 Eric Carlson 2008-12-30 14:23:21 PST

Created attachment 26326 [details]
Proposed patch

Comment 2 Darin Adler 2009-01-01 13:01:43 PST

Comment on attachment 26326 [details]
Proposed patch

> + * Copyright (C) 2008 Apple Computer, Inc.  All rights reserved.

Should be "Apple Inc." not "Apple Computer, Inc."

And now we've been slow enough to review that the publication dates need to be 2009.

r=me

Comment 3 Eric Carlson 2009-01-02 10:35:51 PST

Committed revision 39552.

Comment 4 David Kilzer (:ddkilzer) 2009-01-02 17:04:30 PST

(In reply to comment #3)
> Committed revision 39552.

Follow-up build fix for non-Xcode build systems:

http://trac.webkit.org/changeset/39561