| Summary: | [Cocoa] Support in-band chapter tracks | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | calvaris, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Carlson
2021-09-16 16:37:49 PDT
Created attachment 439370 [details]
Patch
Created attachment 439398 [details]
Patch
Created attachment 439419 [details]
Patch
Comment on attachment 439419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439419&action=review r=me with nits and a question. > Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.h:39 > +class InbandChapterTrackPrivateAVFObjC : public InbandTextTrackPrivate { Nit: final. > Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.h:51 > + int trackIndex() const override { return m_index; } Ditto. > Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.h:59 > + AtomString inBandMetadataTrackDispatchType() const override { return "com.apple.chapters"_s; } Ditto. > Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.mm:74 > + [item loadValuesAsynchronouslyForKeys:@[@"value"] completionHandler:[this, protectedThis = Ref { *this }, item = retainPtr(item), createChapterCue = WTFMove(createChapterCue), chapterNumber, identifier] () mutable { WTFMove(createChapterCue) seems really weird here; won't that mean only the first iteration through the for loop has a valid lambda? Created attachment 439509 [details]
Patch for landing
Comment on attachment 439509 [details]
Patch for landing
The iOS API test failure is unrelated.
Committed r283217 (242259@main): <https://commits.webkit.org/242259@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439509 [details]. |