Summary: | Parsing and reparsing disagree on automatic semicolon insertion | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cameron Zwarich (cpst) <zwarich> | ||||
Component: | JavaScriptCore | Assignee: | Cameron Zwarich (cpst) <zwarich> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | pknight, sam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Cameron Zwarich (cpst)
2008-12-30 11:28:16 PST
Created attachment 26314 [details]
Proposed patch
Comment on attachment 26314 [details]
Proposed patch
I don't think that "during reparsing" is a good name for a boolean. I think that "is reparsing" would be better, or possibly "is reparsing underway".
I don't see any code setting m_duringReparsing back to false. How can subsequent parsing possibly work properly?
It is reset in Lexer::clear() (In reply to comment #3) > (From update of attachment 26314 [details] [review]) > I don't think that "during reparsing" is a good name for a boolean. I think > that "is reparsing" would be better, or possibly "is reparsing underway". I had it like that originally, and it seemed awkward. I'll change it back. > I don't see any code setting m_duringReparsing back to false. How can > subsequent parsing possibly work properly? Like Sam said, it is reset during clear(). |