Summary: | [API Tests] EXPECT_* macros should be used with the expected values first | ||
---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | darin, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Wenson Hsieh
2021-09-16 12:35:03 PDT
Side note: Same applies to the gtest ASSERT macros; they are the same except that they stop the entire test if the assertion fails. I suspect in many cases we are using ASSERT where we should instead be using EXPECT, and likely we have the same backwards mistake. |