Bug 230368

Summary: [API Tests] EXPECT_* macros should be used with the expected values first
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Wenson Hsieh
Reported 2021-09-16 12:35:03 PDT
e.g. EXPECT_EQ(expected, actual) vs. the opposite. Some of our tests flip this order, which can make failure output difficult to understand.
Attachments
Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-09-16 12:38:45 PDT
Side note: Same applies to the gtest ASSERT macros; they are the same except that they stop the entire test if the assertion fails. I suspect in many cases we are using ASSERT where we should instead be using EXPECT, and likely we have the same backwards mistake.
Radar WebKit Bug Importer
Comment 2 2021-09-23 12:35:19 PDT
<rdar://problem/83460692>
Note You need to log in before you can comment on or make changes to this bug.