Bug 230322

Summary: Web Inspector: Regression(r279613) Audit result scope toggles are missing
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Description Flags
Screenshot of Issue
Patch v1.0
Patch v1.1 none

Description Patrick Angle 2021-09-15 15:06:42 PDT
Created attachment 438296 [details]
Screenshot of Issue

Steps to reproduce:
1. Visit nintendolife.com
2. Open Web Inspector
3. Go to the Audit tab
4. Run the accessibility audits
5. Notice that the previously present scope toggles (for showing just passes/just failures) is missing.

See attach screenshot for where they belong. Last time I went looking for these was early June.
Comment 1 Radar WebKit Bug Importer 2021-09-15 15:06:56 PDT
Comment 2 Patrick Angle 2021-09-15 16:51:59 PDT
Created attachment 438303 [details]
Patch v1.0
Comment 3 Patrick Angle 2021-09-16 11:41:17 PDT
Created attachment 438376 [details]
Patch v1.1
Comment 4 Devin Rousso 2021-09-16 15:04:08 PDT
Comment on attachment 438376 [details]
Patch v1.1

r=me, nice fix
Comment 5 Devin Rousso 2021-09-16 15:05:01 PDT
Comment on attachment 438376 [details]
Patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=438376&action=review

> Source/WebInspectorUI/ChangeLog:10
> +        navigation bars. The logic in `WI.NavigationBar.prototype._calculateMinimumWidth` remains unchanged, as we still

I wonder if instead of doing a `Math.ceil` on each item, we could just do it at the very end after the `reduce`?
Comment 6 EWS 2021-09-16 16:06:03 PDT
Committed r282616 (241775@main): <https://commits.webkit.org/241775@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438376 [details].