Bug 230322

Summary: Web Inspector: Regression(r279613) Audit result scope toggles are missing
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot of Issue
none
Patch v1.0
none
Patch v1.1 none

Patrick Angle
Reported 2021-09-15 15:06:42 PDT
Created attachment 438296 [details] Screenshot of Issue Steps to reproduce: 1. Visit nintendolife.com 2. Open Web Inspector 3. Go to the Audit tab 4. Run the accessibility audits 5. Notice that the previously present scope toggles (for showing just passes/just failures) is missing. See attach screenshot for where they belong. Last time I went looking for these was early June.
Attachments
Screenshot of Issue (1.71 MB, image/png)
2021-09-15 15:06 PDT, Patrick Angle 		no flags
Details
Patch v1.0 (3.34 KB, patch)
2021-09-15 16:51 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.1 (2.86 KB, patch)
2021-09-16 11:41 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-15 15:06:56 PDT
<rdar://problem/83169976>
Patrick Angle
Comment 2 2021-09-15 16:51:59 PDT
Created attachment 438303 [details] Patch v1.0
Patrick Angle
Comment 3 2021-09-16 11:41:17 PDT
Created attachment 438376 [details] Patch v1.1
Devin Rousso
Comment 4 2021-09-16 15:04:08 PDT
Comment on attachment 438376 [details] Patch v1.1 r=me, nice fix
Devin Rousso
Comment 5 2021-09-16 15:05:01 PDT
Comment on attachment 438376 [details] Patch v1.1 View in context: https://bugs.webkit.org/attachment.cgi?id=438376&action=review > Source/WebInspectorUI/ChangeLog:10 > + navigation bars. The logic in `WI.NavigationBar.prototype._calculateMinimumWidth` remains unchanged, as we still I wonder if instead of doing a `Math.ceil` on each item, we could just do it at the very end after the `reduce`?
EWS
Comment 6 2021-09-16 16:06:03 PDT
Committed r282616 (241775@main): <https://commits.webkit.org/241775@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438376 [details].
Note You need to log in before you can comment on or make changes to this bug.