Bug 23030

Summary: Cannot setTransform with a non-invertible ctm
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: DOMAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Simple fix + tests zwarich: review+

Description Oliver Hunt 2008-12-29 18:41:02 PST 
Cannot setTransform on a canvas with a non-invertible ctm, cannot begin or close paths, cannot set fill/stroke style.
Comment 1 Oliver Hunt 2008-12-29 19:08:56 PST 
Created attachment 26308 [details]
Simple fix + tests

The fix is simple (i actually noticed the bug through code inspection), test cases are more convoluted (in order to hit the failings paths.
Comment 2 Cameron Zwarich (cpst) 2008-12-29 22:09:03 PST 
Comment on attachment 26308 [details]
Simple fix + tests

r=me
Comment 3 Oliver Hunt 2008-12-29 22:15:43 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/canvas/canvas-set-properties-with-non-invertible-ctm-expected.txt
	A	LayoutTests/fast/canvas/canvas-set-properties-with-non-invertible-ctm.html
	A	LayoutTests/fast/canvas/resources/canvas-set-properties-with-non-invertible-ctm.js
	M	WebCore/ChangeLog
	M	WebCore/html/CanvasRenderingContext2D.cpp
Committed r39508