Bug 230295

Summary:

Move scrollbar-related code out of ScrollAnimator and into ScrollbarsController

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Scrolling

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

230371, 230372

Bug Blocks:

Attachments:

Description	Flags
For EWS	none
Patch	thorton: review+, ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Simon Fraser (smfr)

Reported 2021-09-14 21:31:32 PDT

Move scrollbar-related code out of ScrollAnimator and into ScrollbarsController

Attachments
For EWS (172.85 KB, patch) 2021-09-14 21:34 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (185.89 KB, patch) 2021-09-14 22:55 PDT, Simon Fraser (smfr)	thorton: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (185.42 KB, patch) 2021-09-15 10:36 PDT, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (185.44 KB, patch) 2021-09-15 10:56 PDT, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (188.75 KB, patch) 2021-09-17 19:28 PDT, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (189.14 KB, patch) 2021-09-17 19:37 PDT, Simon Fraser (smfr)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (188.93 KB, patch) 2021-09-17 20:15 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2021-09-14 21:34:35 PDT

Created attachment 438210 [details] For EWS

Simon Fraser (smfr)

Comment 2 2021-09-14 22:55:21 PDT

Created attachment 438215 [details] Patch

Tim Horton

Comment 3 2021-09-15 00:09:06 PDT

Comment on attachment 438215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438215&action=review Best make it build. > Source/WebCore/Sources.txt:1821 > +platform/ScrollbarsController.cpp I am vaguely surprised about the plural. > Source/WebCore/platform/mac/ScrollbarsControllerMac.mm:197 > + RetainPtr<NSTimer> _timer; Cocoa timer instead of ours is kind of surprising, though I suppose not a problem and not new?

Simon Fraser (smfr)

Comment 4 2021-09-15 10:36:57 PDT

Created attachment 438258 [details] Patch

Simon Fraser (smfr)

Comment 5 2021-09-15 10:56:06 PDT

Created attachment 438259 [details] Patch

Simon Fraser (smfr)

Comment 6 2021-09-15 22:55:17 PDT

The WK1 test failure are about the timing of the call to intgernals.setUsesMockScrollAnimator() vs creation of ScrollAnimator. The test has different results on first and second runs.

Simon Fraser (smfr)

Comment 7 2021-09-17 19:28:53 PDT

Created attachment 438542 [details] Patch

Simon Fraser (smfr)

Comment 8 2021-09-17 19:37:20 PDT

Created attachment 438543 [details] Patch

Simon Fraser (smfr)

Comment 9 2021-09-17 20:15:22 PDT

Created attachment 438545 [details] Patch

EWS

Comment 10 2021-09-17 21:25:01 PDT

Committed r282720 (241857@main): <https://commits.webkit.org/241857@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438545 [details].

Radar WebKit Bug Importer

Comment 11 2021-09-17 21:26:18 PDT

<rdar://problem/83265293>

Note You need to log in before you can comment on or make changes to this bug.