| Summary: | Move scrollbar-related code out of ScrollAnimator and into ScrollbarsController | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||
| Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | simon.fraser, thorton, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | 230371, 230372 | ||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Simon Fraser (smfr)
2021-09-14 21:31:32 PDT
Created attachment 438210 [details]
For EWS
Created attachment 438215 [details]
Patch
Comment on attachment 438215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438215&action=review Best make it build. > Source/WebCore/Sources.txt:1821 > +platform/ScrollbarsController.cpp I am vaguely surprised about the plural. > Source/WebCore/platform/mac/ScrollbarsControllerMac.mm:197 > + RetainPtr<NSTimer> _timer; Cocoa timer instead of ours is kind of surprising, though I suppose not a problem and not new? Created attachment 438258 [details]
Patch
Created attachment 438259 [details]
Patch
The WK1 test failure are about the timing of the call to intgernals.setUsesMockScrollAnimator() vs creation of ScrollAnimator. The test has different results on first and second runs. Created attachment 438542 [details]
Patch
Created attachment 438543 [details]
Patch
Created attachment 438545 [details]
Patch
Committed r282720 (241857@main): <https://commits.webkit.org/241857@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438545 [details]. |