| Summary: | Addition of CSSTransformValue, CSSTransformComponent & subclasses | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Qiaosong Zhou <johnson.zhou.sh> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Qiaosong Zhou <johnson.zhou.sh> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, benjamin, calvaris, cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 175733 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Qiaosong Zhou
2021-09-14 16:38:40 PDT
Created attachment 438189 [details]
Patch
Comment on attachment 438189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438189&action=review probably needs some test expectations to be updated. > Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp:58 > + return ""_s; FIXME: Implement. > Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp:63 > + return DOMMatrix::fromMatrix(DOMMatrixInit { }); ditto > Source/WebCore/css/typedom/transform/CSSSkew.h:54 > + Ref<CSSNumericValue> m_ax, m_ay; We usually put variable declarations on their own line with the type repeated in WebKit. > Source/WebCore/css/typedom/transform/CSSTranslate.h:56 > + Ref<CSSNumericValue> m_x, m_y; ditto Created attachment 438198 [details]
Patch
Comment on attachment 438198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438198&action=review > Source/WebCore/css/typedom/transform/CSSTransformComponent.h:38 > + WTF_MAKE_ISO_ALLOCATED(CSSTransformComponent); Looks like you need to #include <wtf/IsoMalloc.h> Created attachment 438224 [details]
Patch
Created attachment 438272 [details]
Patch
WPT test crashes are due to the lack of CustomToJSObject wrapper. Fixing. Created attachment 438422 [details]
Patch
Created attachment 438424 [details]
Patch
Comment on attachment 438424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438424&action=review > Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp:2 > + * Copyright (C) 2018 Apple Inc. All rights reserved. 2021 > Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp:46 > + if (is<CSSMatrixComponent>(value.get())) Can this be a switch statement instead? > Source/WebCore/css/typedom/transform/CSSTransformComponent.h:61 > + nit: extra space Created attachment 438515 [details]
Patch
Comment on attachment 438515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438515&action=review > Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp:33 > + nit: extra space > Source/WebCore/css/typedom/transform/CSSTransformComponent.h:61 > + nit: extra space. > Source/WebCore/css/typedom/transform/CSSTransformComponent.h:63 > + bool m_is2D; This is uninitialized memory. I'll add { false } while landing. > Source/WebCore/css/typedom/transform/CSSTransformValue.h:56 > + bool m_is2D; ditto Comment on attachment 438515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438515&action=review > Source/WebCore/css/typedom/transform/CSSMatrixComponentOptions.h:33 > + bool is2D; Here too. Created attachment 438526 [details]
Patch
|