Bug 230279

Summary: Rename RESOURCE_LOAD_STATISTICS to INTELLIGENT_TRACKING_PREVENTION
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, berto, bfulgham, cdumez, cgarcia, cmarcelo, darin, don.olmstead, esprehn+autocc, ews-watchlist, galpeter, gustavo, gyuyoung.kim, japhet, jbedard, kangil.han, kondapallykalyan, ryuan.choi, sergio, toyoshim, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for FeatureList none

Description John Wilander 2021-09-14 15:08:24 PDT 
We're long overdue to rename RESOURCE_LOAD_STATISTICS to INTELLIGENT_TRACKING_PREVENTION which is the name most people know.
Comment 1 Radar WebKit Bug Importer 2021-09-14 15:08:54 PDT 
<rdar://problem/83118683>
Comment 2 John Wilander 2021-09-14 15:25:15 PDT 
Created attachment 438180 [details]
Patch
Comment 3 John Wilander 2021-09-14 15:33:01 PDT 
Created attachment 438181 [details]
Patch
Comment 4 Darin Adler 2021-09-14 16:27:16 PDT 
Comment on attachment 438181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438181&action=review

> Source/cmake/OptionsFTW.cmake:151
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_POINTER_LOCK PRIVATE OFF)
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE OFF)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE OFF)
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/OptionsGTK.cmake:170
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_POINTER_LOCK PRIVATE ON)
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ON)
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/OptionsMac.cmake:76
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESIZE_OBSERVER PRIVATE ON)
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ON)
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/OptionsWPE.cmake:65
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PERIODIC_MEMORY_MONITOR PRIVATE ON)
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ON)
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/OptionsWin.cmake:83
>      WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
> -    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
> +    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
>      WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/WebKitFeatures.cmake:201
>      WEBKIT_OPTION_DEFINE(ENABLE_RESIZE_OBSERVER "Toggle Resize Observer support" PRIVATE ON)
> -    WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_LOAD_STATISTICS "Toggle resource load statistics support" PRIVATE OFF)
> +    WEBKIT_OPTION_DEFINE(ENABLE_INTELLIGENT_TRACKING_PREVENTION "Toggle resource load statistics support" PRIVATE OFF)
>      WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_USAGE "Toggle resource usage support" PRIVATE OFF)

Looks like this was sorted alphabetically before. Should move it.
Comment 5 John Wilander 2021-09-14 16:48:21 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 438181 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438181&action=review
> 
> > Source/cmake/OptionsFTW.cmake:151
> >  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_POINTER_LOCK PRIVATE OFF)
> > -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE OFF)
> > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE OFF)
> >  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)
> 
> Looks like this was sorted alphabetically before. Should move it.
> 
> > Source/cmake/OptionsGTK.cmake:170
> >  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_POINTER_LOCK PRIVATE ON)
> > -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ON)
> >  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)
> 
> Looks like this was sorted alphabetically before. Should move it.
> 
> > Source/cmake/OptionsMac.cmake:76
> >  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESIZE_OBSERVER PRIVATE ON)
> > -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ON)
> >  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)
> 
> Looks like this was sorted alphabetically before. Should move it.
> 
> > Source/cmake/OptionsWPE.cmake:65
> >  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PERIODIC_MEMORY_MONITOR PRIVATE ON)
> > -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ON)
> >  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)
> 
> Looks like this was sorted alphabetically before. Should move it.
> 
> > Source/cmake/OptionsWin.cmake:83
> >      WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
> > -    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
> > +    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
> >      WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
> 
> Looks like this was sorted alphabetically before. Should move it.
> 
> > Source/cmake/WebKitFeatures.cmake:201
> >      WEBKIT_OPTION_DEFINE(ENABLE_RESIZE_OBSERVER "Toggle Resize Observer support" PRIVATE ON)
> > -    WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_LOAD_STATISTICS "Toggle resource load statistics support" PRIVATE OFF)
> > +    WEBKIT_OPTION_DEFINE(ENABLE_INTELLIGENT_TRACKING_PREVENTION "Toggle resource load statistics support" PRIVATE OFF)
> >      WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_USAGE "Toggle resource usage support" PRIVATE OFF)
> 
> Looks like this was sorted alphabetically before. Should move it.

Thanks, Darin! I'll fix the ordering before landing.
Comment 6 John Wilander 2021-09-14 17:15:35 PDT 
Created attachment 438192 [details]
Patch for landing
Comment 7 EWS 2021-09-14 18:13:53 PDT 
Committed r282429 (241688@main): <https://commits.webkit.org/241688@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438192 [details].
Comment 8 Don Olmstead 2021-09-14 18:47:15 PDT 
Reopening for follow-up fix for the perl script.
Comment 9 Don Olmstead 2021-09-14 18:50:06 PDT 
Created attachment 438204 [details]
Patch for FeatureList
Comment 10 John Wilander 2021-09-14 19:41:21 PDT 
Comment on attachment 438204 [details]
Patch for FeatureList

Thanks, Don!
Comment 11 EWS 2021-09-14 20:39:59 PDT 
Committed r282431 (241690@main): <https://commits.webkit.org/241690@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438204 [details].