Bug 230244

Summary:

Implement text-decoration-skip-ink

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bruno.abinader, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
Patch	none
Patch	none
Patch	koivisto: review+, ews-feeder: commit-queue-

Description Myles C. Maxfield 2021-09-13 21:33:35 PDT

Implement text-decoration-skip-ink

Comment 1 Myles C. Maxfield 2021-09-13 21:35:37 PDT

Created attachment 438100 [details]
WIP

Comment 2 Myles C. Maxfield 2021-09-13 23:28:35 PDT

Failing tests:

fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html
imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties.html
imported/w3c/web-platform-tests/css/css-text-decor/inheritance.html
imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-computed.html
imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-valid.html
imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink.html
imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html

Comment 3 Myles C. Maxfield 2021-09-14 00:41:04 PDT

Created attachment 438109 [details]
Patch

Comment 4 Myles C. Maxfield 2021-09-14 00:52:29 PDT

Created attachment 438110 [details]
Patch

Comment 5 Myles C. Maxfield 2021-09-14 02:30:04 PDT

Created attachment 438116 [details]
Patch

Comment 6 Antti Koivisto 2021-09-14 06:27:34 PDT

Comment on attachment 438116 [details]
Patch

Seems reasonable, r=me

Comment 7 Myles C. Maxfield 2021-09-14 11:39:11 PDT

Committed r282397 (241658@main): <https://commits.webkit.org/241658@main>

Comment 8 Radar WebKit Bug Importer 2021-09-14 11:40:38 PDT

<rdar://problem/83109958>

Comment 9 Darin Adler 2021-09-14 16:42:58 PDT

Comment on attachment 438116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438116&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:1681
> +    if (RefPtr<CSSPrimitiveValue> skip = consumeIdent<CSSValueNone, CSSValueAuto, CSSValueInk>(m_range)) {

auto

Comment 10 Tim Nguyen (:ntim) 2022-05-19 07:09:17 PDT

*** Bug 95848 has been marked as a duplicate of this bug. ***