Bug 230236

Summary: Implement network process crash recovery for BroadcastChannel
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, darin, ggaren, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161472    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2021-09-13 16:26:40 PDT
Implement network process crash recovery for BroadcastChannel. Currently, if the network process crashes and relaunches, pre-existing BroadcastChannels will be broken (communication won't be possible between WebProcesses).
Attachments
Patch (10.34 KB, patch)
2021-09-15 08:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.23 KB, patch)
2021-09-15 11:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-09-15 08:39:59 PDT
Created attachment 438247 [details] Patch
Darin Adler
Comment 2 2021-09-15 11:20:33 PDT
Comment on attachment 438247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438247&action=review > Source/WebKit/WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp:113 > + for (auto& channelsPerOriginEntry : m_channelsPerOrigin) { > + auto& origin = channelsPerOriginEntry.key; > + auto& channelsForOrigin = channelsPerOriginEntry.value; I believe we can write this with de-structuring and save many lines of code: for (auto& [origin, channelsForOrigin] : m_channelsPerOrigin) { But I haven’t tried it. Seems like it would be better if it works.
Chris Dumez
Comment 3 2021-09-15 11:32:46 PDT
Created attachment 438267 [details] Patch
EWS
Comment 4 2021-09-15 18:02:27 PDT
Committed r282483 (241731@main): <https://commits.webkit.org/241731@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438267 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-15 18:03:27 PDT
<rdar://problem/83176366>
Note You need to log in before you can comment on or make changes to this bug.