Bug 230236

Summary: Implement network process crash recovery for BroadcastChannel
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, darin, ggaren, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161472    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2021-09-13 16:26:40 PDT 
Implement network process crash recovery for BroadcastChannel. Currently, if the network process crashes and relaunches, pre-existing BroadcastChannels will be broken (communication won't be possible between WebProcesses).
Comment 1 Chris Dumez 2021-09-15 08:39:59 PDT 
Created attachment 438247 [details]
Patch
Comment 2 Darin Adler 2021-09-15 11:20:33 PDT 
Comment on attachment 438247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438247&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp:113
> +    for (auto& channelsPerOriginEntry : m_channelsPerOrigin) {
> +        auto& origin = channelsPerOriginEntry.key;
> +        auto& channelsForOrigin = channelsPerOriginEntry.value;

I believe we can write this with de-structuring and save many lines of code:

    for (auto& [origin, channelsForOrigin] : m_channelsPerOrigin) {

But I haven’t tried it. Seems like it would be better if it works.
Comment 3 Chris Dumez 2021-09-15 11:32:46 PDT 
Created attachment 438267 [details]
Patch
Comment 4 EWS 2021-09-15 18:02:27 PDT 
Committed r282483 (241731@main): <https://commits.webkit.org/241731@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438267 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-15 18:03:27 PDT 
<rdar://problem/83176366>