Summary: | REGRESSION(r282278): ASSERTION FAILED: !m_needExceptionCheck in JSC::VM::verifyExceptionCheckNeedIsSatisfied | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebCore Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=230207 | ||||||||
Bug Depends on: | 230146 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Fujii Hironori
2021-09-12 21:26:30 PDT
Created attachment 438019 [details]
Patch
This is not WinCairo specific issue. Other bug (Bug 230207) seems to hide this. Fixing Bug 230207 reveals this for Mac port. Comment on attachment 438019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438019&action=review > Source/WebCore/bindings/js/InternalWritableStream.cpp:47 > auto result = call(&globalObject, function, callData, JSC::jsUndefined(), arguments); Can we also change the if(UNLIKELY(...) return Exception... with: RETURN_IF_EXCEPTION(scope, Exception { ExistingExceptionError }); This is more inline with other parts of the codebase. Created attachment 438066 [details]
Patch for landing
Comment on attachment 438066 [details] Patch for landing Clearing flags on attachment: 438066 Committed r282351 (241617@main): <https://commits.webkit.org/241617@main> All reviewed patches have been landed. Closing bug. |