Bug 230155

Summary:

Factor more text painting functions to TextBoxPainter

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Antti Koivisto <koivisto>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none

Description Antti Koivisto 2021-09-10 09:09:05 PDT

from LegacyInlineTextBox

Comment 1 Antti Koivisto 2021-09-10 09:15:58 PDT

Created attachment 437878 [details]
Patch

Comment 2 Antti Koivisto 2021-09-10 09:23:38 PDT

Created attachment 437882 [details]
Patch

Comment 3 zalan 2021-09-10 09:54:06 PDT

Comment on attachment 437882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437882&action=review

> Source/WebCore/rendering/TextBoxPainter.cpp:368
> +    auto y = ascent + 0.11035 * fontSize;
> +    auto height = 0.13247 * fontSize;

science.

Comment 4 EWS 2021-09-10 10:16:50 PDT

Committed r282277 (241555@main): <https://commits.webkit.org/241555@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437882 [details].

Comment 5 Radar WebKit Bug Importer 2021-09-10 10:17:22 PDT

<rdar://problem/82978035>