Bug 230147

Summary: Factor painting functions from LegacyInlineTextBox into a class
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dpino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, megan_gardner, mmaxfield, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ews-feeder: commit-queue-
patch
none
patch
ews-feeder: commit-queue-
patch
ews-feeder: commit-queue-
patch
none
Patch none

Description Antti Koivisto 2021-09-10 05:28:14 PDT 
Add TextBoxPainter
Comment 1 Antti Koivisto 2021-09-10 05:34:08 PDT 
Created attachment 437852 [details]
patch
Comment 2 Antti Koivisto 2021-09-10 05:56:22 PDT 
Created attachment 437855 [details]
patch
Comment 3 Antti Koivisto 2021-09-10 05:59:16 PDT 
Created attachment 437856 [details]
patch
Comment 4 Antti Koivisto 2021-09-10 06:14:39 PDT 
Created attachment 437858 [details]
patch
Comment 5 Antti Koivisto 2021-09-10 06:29:03 PDT 
Created attachment 437861 [details]
patch
Comment 6 Antti Koivisto 2021-09-10 06:39:54 PDT 
Created attachment 437863 [details]
Patch
Comment 7 zalan 2021-09-10 08:04:06 PDT 
Comment on attachment 437863 [details]
Patch

omg it's happening!!!
Comment 8 EWS 2021-09-10 08:20:47 PDT 
Committed r282270 (241548@main): <https://commits.webkit.org/241548@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437863 [details].
Comment 9 Radar WebKit Bug Importer 2021-09-10 09:13:52 PDT 
<rdar://problem/82975105>
Comment 10 Diego Pino 2021-09-13 01:36:28 PDT 
This patch broke Ubuntu LTS/Debian compilation.

https://build.webkit.org/#/builders/68/builds/6472

Fixed in https://trac.webkit.org/changeset/282321/webkit